-
Notifications
You must be signed in to change notification settings - Fork 901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Book 3.4: Sphere Importance Sampling #1500
Comments
Good point. I don't know if I would have made the connection myself. I would actually expound on this a bit further. Something like:
I'm still missing where the |
@rupsis @hollasch I think you guys got this wrong. 😺 From scalar projection we know that projection of vector In our case we have random vector So, in our function |
See also #1536. Things are a bit muddy in this region of the text. |
Perhaps I'm just slow, but for Listing 16, the
f()
function took me a little while to figure out.If I understand correctly,$cos(\theta)^2$ here is $(\cos(0^\circ) *z)^2$ (where Z is from the $cos(0^\circ) = 1$ we're left with
random_unit_vector
)and since
d.z()*d.z()
.The text doesn't make that obvious. Perhaps (and very likely) the issue is me. But if my understanding is correct, maybe some clarification could be useful. A small attempt on my part:
The text was updated successfully, but these errors were encountered: