build: update upload artifact to v4

Author: johannesjo

.github/workflows/build-android.yml

@@ -59,7 +59,7 @@ jobs:
           RELEASE_KEY_PASSWORD: ${{ secrets.DROID_KEY_PASSWORD }}
 
       - name: 'Upload Artifact'
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: sup-android-release
           path: android/app/build/outputs/*/*

.github/workflows/build-create-windows-store-on-release.yml

@@ -77,7 +77,7 @@ jobs:
           github_token: ${{ secrets.github_token }}
 
       - name: 'Upload Artifact'
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: WinStoreRelease
           path: app-builds/*.appx

.github/workflows/build.yml

@@ -50,13 +50,13 @@ jobs:
       - name: Test E2E
         run: npm run e2e
       - name: Upload performance metrics as an artifact
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: nightwatch-performance-metrics
           path: perf-metrics*.json
       - name: 'Upload E2E screenshots on failure'
         if: ${{ always() }}
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: e2eScreenshots
           path: e2e/screenshots/**/*.*

.github/workflows/lint-and-test-pr.yml

@@ -42,7 +42,7 @@ jobs:
       - run: npm run test
       - run: npm run e2e
       - name: Upload performance metrics as an artifact
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: nightwatch-performance-metrics
           path: perf-metrics*.json
@@ -68,7 +68,7 @@ jobs:
 
       - name: 'Upload E2E screenshots on failure'
         if: ${{ always() }}
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: e2eScreenshots
           path: e2e/screenshots/**/*.*

.github/workflows/manual-build.yml

@@ -55,7 +55,7 @@ jobs:
           release: false
 
       - name: 'Upload Artifact'
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: WinBuildStuff
           path: app-builds/*.exe
@@ -150,7 +150,7 @@ jobs:
       #  if: always()
       # run: ls -la && cat notarization-error.log
       - name: 'Upload Artifact'
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: dmg
           path: app-builds/*.dmg