Skip to content

Commit 31ca826

Browse files
refactor: Rename URL helper methods for consistency
- Swap and rename `promo_detail_url` → `get_user_promo_detail_url` and `get_promo_business_detail_url` → `get_business_promo_detail_url` - Improve readability and ensure consistent naming across tests
1 parent 27e6633 commit 31ca826

File tree

3 files changed

+11
-10
lines changed

3 files changed

+11
-10
lines changed

promo_code/user/tests/user/base.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -69,20 +69,21 @@ def tearDown(self):
6969
business.models.Promo.objects.all().delete()
7070
business.models.PromoCode.objects.all().delete()
7171
user.models.User.objects.all().delete()
72+
user.models.PromoLike.objects.all().delete()
7273
tb_models.BlacklistedToken.objects.all().delete()
7374
tb_models.OutstandingToken.objects.all().delete()
7475
super().tearDown()
7576

7677
@classmethod
77-
def promo_detail_url(cls, promo_id):
78+
def get_business_promo_detail_url(cls, promo_id):
7879
return django.urls.reverse(
79-
'api-user:user-promo-detail',
80+
'api-business:promo-detail',
8081
kwargs={'id': promo_id},
8182
)
8283

8384
@classmethod
84-
def get_promo_business_detail_url(cls, promo_id):
85+
def get_user_promo_detail_url(cls, promo_id):
8586
return django.urls.reverse(
86-
'api-business:promo-detail',
87+
'api-user:user-promo-detail',
8788
kwargs={'id': promo_id},
8889
)

promo_code/user/tests/user/operations/test_detail.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ def setUp(self):
8282
self.client.credentials(HTTP_AUTHORIZATION='Bearer ' + self.user_token)
8383

8484
def test_get_promo_matching_target(self):
85-
url = self.promo_detail_url(self.promo_sg_id)
85+
url = self.get_user_promo_detail_url(self.promo_sg_id)
8686
response = self.client.get(url)
8787
self.assertEqual(
8888
response.status_code,
@@ -94,7 +94,7 @@ def test_get_promo_matching_target(self):
9494
)
9595

9696
def test_get_promo_non_matching_target(self):
97-
url = self.promo_detail_url(self.promo_kz_id)
97+
url = self.get_user_promo_detail_url(self.promo_kz_id)
9898
response = self.client.get(url)
9999
self.assertEqual(
100100
response.status_code,
@@ -118,7 +118,7 @@ def test_get_promo_non_matching_target(self):
118118
)
119119
def test_user_promo_detail(self, promo_attr, forbidden_field):
120120
promo_id = getattr(self, promo_attr)
121-
url = self.promo_detail_url(promo_id)
121+
url = self.get_user_promo_detail_url(promo_id)
122122
response = self.client.get(url, format='json')
123123
self.assertEqual(
124124
response.status_code,
@@ -132,7 +132,7 @@ def test_user_promo_detail(self, promo_attr, forbidden_field):
132132

133133
def test_get_promo_invalid_token(self):
134134
self.client.credentials(HTTP_AUTHORIZATION='Bearer invalid.jwt.token')
135-
url = self.promo_detail_url(self.promo_kz_id)
135+
url = self.get_user_promo_detail_url(self.promo_kz_id)
136136
response = self.client.get(url)
137137
self.assertEqual(
138138
response.status_code,
@@ -141,7 +141,7 @@ def test_get_promo_invalid_token(self):
141141

142142
def test_get_promo_not_found(self):
143143
random_uuid = uuid.UUID('550e8400-e29b-41d4-a716-446655440000')
144-
url = self.promo_detail_url(random_uuid)
144+
url = self.get_user_promo_detail_url(random_uuid)
145145
response = self.client.get(url)
146146
self.assertEqual(
147147
response.status_code,

promo_code/user/tests/user/operations/test_feed.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -654,7 +654,7 @@ def test_user4_sg_80_get_all_promos_after_edit(self):
654654
self.client.credentials(
655655
HTTP_AUTHORIZATION='Bearer ' + self.company2_token,
656656
)
657-
url = self.get_promo_business_detail_url(self.promo11_id)
657+
url = self.get_business_promo_detail_url(self.promo11_id)
658658
patch_data = {'active_until': '2024-08-10'}
659659
response = self.client.patch(url, patch_data, format='json')
660660
self.assertEqual(

0 commit comments

Comments
 (0)