Skip to content

Commit 006122c

Browse files
committed
cleaned up tests for consistency and replicatibility
1 parent 98e68a9 commit 006122c

File tree

2 files changed

+8
-17
lines changed

2 files changed

+8
-17
lines changed

cobertura.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
<?xml version="1.0"?><coverage lines-covered="236" lines-valid="247" line-rate="0.9554655870445344" branches-covered="0" branches-valid="0" branch-rate="0" complexity="0" version="1.9" timestamp="1764643426"><sources><source>/home/alex/Projects/sql-docs</source></sources><packages><package name="src" line-rate="0.9554655870445344" branch-rate="0" complexity="0"><classes><class name="ast" filename="src/ast.rs" line-rate="1" branch-rate="0" complexity="0"><methods/><lines><line number="31" hits="24"/><line number="32" hits="48"/><line number="33" hits="96"/><line number="34" hits="24"/><line number="39" hits="16"/><line number="40" hits="16"/><line number="45" hits="1"/><line number="46" hits="1"/><line number="51" hits="16"/><line number="52" hits="16"/><line number="57" hits="14"/><line number="58" hits="14"/><line number="75" hits="7"/><line number="76" hits="35"/><line number="78" hits="7"/><line number="83" hits="7"/><line number="84" hits="7"/></lines></class><class name="comments" filename="src/comments.rs" line-rate="0.9137931034482759" branch-rate="0" complexity="0"><methods/><lines><line number="25" hits="170"/><line number="31" hits="482"/><line number="32" hits="482"/><line number="37" hits="15"/><line number="38" hits="15"/><line number="43" hits="14"/><line number="44" hits="14"/><line number="63" hits="149"/><line number="69" hits="13"/><line number="70" hits="13"/><line number="75" hits="482"/><line number="76" hits="482"/><line number="81" hits="3"/><line number="82" hits="9"/><line number="99" hits="121"/><line number="100" hits="121"/><line number="101" hits="242"/><line number="120" hits="148"/><line number="126" hits="121"/><line number="127" hits="121"/><line number="132" hits="495"/><line number="133" hits="495"/><line number="139" hits="77"/><line number="140" hits="77"/><line number="160" hits="6"/><line number="161" hits="6"/><line number="162" hits="5"/><line number="163" hits="5"/><line number="164" hits="5"/><line number="166" hits="10"/><line number="167" hits="10"/><line number="170" hits="1"/><line number="171" hits="1"/><line number="172" hits="1"/><line number="174" hits="2"/><line number="175" hits="2"/><line number="200" hits="1"/><line number="202" hits="3"/><line number="203" hits="3"/><line number="204" hits="3"/><line number="206" hits="1"/><line number="207" hits="1"/><line number="208" hits="2"/><line number="209" hits="4"/><line number="225" hits="15"/><line number="226" hits="45"/><line number="227" hits="45"/><line number="228" hits="15"/><line number="241" hits="15"/><line number="242" hits="30"/><line number="244" hits="30"/><line number="245" hits="30"/><line number="247" hits="30"/><line number="248" hits="30"/><line number="250" hits="30"/><line number="251" hits="30"/><line number="253" hits="30"/><line number="255" hits="60"/><line number="257" hits="21113"/><line number="258" hits="21098"/><line number="260" hits="216"/><line number="261" hits="216"/><line number="262" hits="144"/><line number="263" hits="144"/><line number="264" hits="144"/><line number="265" hits="144"/><line number="266" hits="72"/><line number="270" hits="216"/><line number="271" hits="216"/><line number="272" hits="144"/><line number="273" hits="144"/><line number="274" hits="144"/><line number="275" hits="144"/><line number="276" hits="72"/><line number="280" hits="0"/><line number="281" hits="0"/><line number="282" hits="0"/><line number="285" hits="72"/><line number="286" hits="360"/><line number="287" hits="288"/><line number="288" hits="144"/><line number="289" hits="288"/><line number="291" hits="144"/><line number="292" hits="72"/><line number="295" hits="216"/><line number="296" hits="216"/><line number="297" hits="360"/><line number="298" hits="288"/><line number="299" hits="144"/><line number="300" hits="288"/><line number="302" hits="144"/><line number="303" hits="144"/><line number="304" hits="72"/><line number="306" hits="0"/><line number="309" hits="48"/><line number="310" hits="48"/><line number="312" hits="8256"/><line number="313" hits="8256"/><line number="315" hits="6085"/><line number="320" hits="10944"/><line number="321" hits="395"/><line number="322" hits="395"/><line number="324" hits="10154"/><line number="329" hits="15"/><line number="330" hits="0"/><line number="331" hits="0"/><line number="335" hits="15"/><line number="336" hits="0"/><line number="337" hits="0"/><line number="338" hits="0"/><line number="339" hits="0"/><line number="343" hits="15"/><line number="348" hits="109"/><line number="349" hits="109"/><line number="359" hits="99"/><line number="360" hits="1239"/></lines></class><class name="docs" filename="src/docs.rs" line-rate="0.9743589743589743" branch-rate="0" complexity="0"><methods/><lines><line number="22" hits="163"/><line number="28" hits="9"/><line number="29" hits="9"/><line number="35" hits="8"/><line number="36" hits="8"/><line number="58" hits="37"/><line number="65" hits="6"/><line number="66" hits="6"/><line number="72" hits="3"/><line number="73" hits="3"/><line number="79" hits="3"/><line number="80" hits="3"/><line number="97" hits="10"/><line number="111" hits="9"/><line number="112" hits="18"/><line number="113" hits="36"/><line number="115" hits="18"/><line number="116" hits="18"/><line number="117" hits="36"/><line number="118" hits="36"/><line number="119" hits="180"/><line number="120" hits="162"/><line number="121" hits="324"/><line number="122" hits="243"/><line number="123" hits="162"/><line number="124" hits="63"/><line number="125" hits="189"/><line number="127" hits="54"/><line number="129" hits="243"/><line number="131" hits="72"/><line number="132" hits="36"/><line number="134" hits="28"/><line number="135" hits="14"/><line number="136" hits="14"/><line number="138" hits="20"/><line number="140" hits="54"/><line number="143" hits="0"/><line number="152" hits="5"/><line number="153" hits="5"/></lines></class><class name="files" filename="src/files.rs" line-rate="1" branch-rate="0" complexity="0"><methods/><lines><line number="18" hits="2"/><line number="19" hits="10"/><line number="25" hits="6"/><line number="26" hits="6"/><line number="53" hits="13"/><line number="54" hits="39"/><line number="55" hits="22"/><line number="56" hits="6"/><line number="57" hits="26"/><line number="59" hits="8"/><line number="62" hits="10"/><line number="67" hits="8"/><line number="68" hits="8"/><line number="73" hits="2"/><line number="74" hits="8"/><line number="75" hits="2"/><line number="76" hits="2"/><line number="88" hits="19"/><line number="89" hits="38"/><line number="90" hits="88"/><line number="91" hits="94"/><line number="92" hits="141"/><line number="93" hits="291"/><line number="94" hits="68"/><line number="95" hits="47"/><line number="96" hits="15"/><line number="97" hits="15"/><line number="100" hits="16"/><line number="118" hits="27"/><line number="119" hits="81"/><line number="120" hits="52"/><line number="125" hits="17"/><line number="126" hits="17"/><line number="131" hits="40"/><line number="132" hits="40"/><line number="155" hits="9"/><line number="156" hits="36"/><line number="158" hits="16"/><line number="161" hits="58"/><line number="164" hits="8"/><line number="168" hits="1"/><line number="169" hits="1"/><line number="177" hits="7"/><line number="178" hits="14"/></lines></class><class name="lib" filename="src/lib.rs" line-rate="1" branch-rate="0" complexity="0"><methods/><lines><line number="39" hits="3"/><line number="40" hits="3"/><line number="41" hits="4"/><line number="42" hits="1"/><line number="43" hits="3"/><line number="45" hits="4"/><line number="51" hits="3"/><line number="52" hits="3"/><line number="53" hits="2"/><line number="54" hits="2"/><line number="55" hits="2"/><line number="61" hits="1"/><line number="62" hits="1"/><line number="67" hits="1"/><line number="68" hits="1"/><line number="73" hits="1"/><line number="74" hits="1"/><line number="95" hits="2"/><line number="100" hits="18"/><line number="102" hits="8"/><line number="104" hits="8"/><line number="106" hits="6"/><line number="107" hits="4"/><line number="109" hits="9"/><line number="110" hits="15"/><line number="111" hits="20"/><line number="112" hits="15"/><line number="113" hits="15"/><line number="115" hits="2"/><line number="134" hits="1"/><line number="137" hits="3"/></lines></class></classes></package></packages></coverage>

src/lib.rs

Lines changed: 7 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -183,10 +183,8 @@ fn test_with_no_deny_list_from_files() {
183183
let Ok(generated_docs) = generate_docs_from_dir_no_deny("sql_files") else {
184184
panic!("unable to locate test dir");
185185
};
186-
let mut actual_paths: Vec<String> = generated_docs
187-
.iter()
188-
.map(|(path, _)| path.to_string_lossy().into_owned())
189-
.collect();
186+
let mut actual_paths: Vec<String> =
187+
generated_docs.iter().map(|(path, _)| path.to_string_lossy().into_owned()).collect();
190188
actual_paths.sort();
191189
let mut expected_paths = vec![
192190
"sql_files/without_comments.sql".to_string(),
@@ -197,24 +195,16 @@ fn test_with_no_deny_list_from_files() {
197195
expected_paths.sort();
198196
assert_eq!(actual_paths, expected_paths);
199197
let target = Path::new("sql_files/with_mixed_comments.sql");
200-
let Some((_, mixed_docs)) = generated_docs
201-
.iter()
202-
.find(|(path, _)| path.as_path() == target)
198+
let Some((_, mixed_docs)) = generated_docs.iter().find(|(path, _)| path.as_path() == target)
203199
else {
204200
panic!("with_mixed_comments.sql should be present");
205201
};
206202
let table_names = ["users", "posts"];
207-
let table_comments = [
208-
"Users table stores user account information",
209-
"Posts table stores blog posts",
210-
];
203+
let table_comments =
204+
["Users table stores user account information", "Posts table stores blog posts"];
211205
let user_columns = ["id", "username", "email", "created_at"];
212-
let user_columns_comments = [
213-
"Primary key",
214-
"Username for login",
215-
"Email address",
216-
"When the user registered",
217-
];
206+
let user_columns_comments =
207+
["Primary key", "Username for login", "Email address", "When the user registered"];
218208
for (i, table) in mixed_docs.tables().iter().enumerate() {
219209
assert_eq!(table.name(), table_names[i]);
220210

0 commit comments

Comments
 (0)