Merge pull request #3078 from ROCm/fix-memory-leak-tensor-descriptor-tf2.18

AleksaArsic · web-flow · commit 8d268020294a · 2025-08-07T12:09:47.000+02:00
[FIX][TF2.18] Memory leak of ScopedDescriptor object
diff --git a/third_party/xla/xla/stream_executor/rocm/rocm_dnn.cc b/third_party/xla/xla/stream_executor/rocm/rocm_dnn.cc
@@ -858,7 +858,7 @@ struct ScopedDescriptor {
   }
 
   ~ScopedDescriptor() {
-    if (handle_ != nullptr) return;
+    if (handle_ == nullptr) return;
 
     auto status = miDestroyObject(
         handle_);  // wrap::miopenDestroyTensorDescriptor(handle_);

Original file line number	Diff line number	Diff line change
`@@ -858,7 +858,7 @@ struct ScopedDescriptor {`
`858`	`858`	`}`
`859`	`859`
`860`	`860`	`~ScopedDescriptor() {`
`861`		`- if (handle_ != nullptr) return;`
	`861`	`+ if (handle_ == nullptr) return;`
`862`	`862`
`863`	`863`	`auto status = miDestroyObject(`
`864`	`864`	`handle_); // wrap::miopenDestroyTensorDescriptor(handle_);`