rocr: SvmPrefetch to a particular node #294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously regardless of hsa_agent passed the prefetch is always driven to node 0, now the agent of interest may be properly prefetched. Signed-off-by: Sunday Clement <Sunday.Clement@amd.com>
…evelop/ROCm_ROCR-Runtime/sclement_SWDEV-548802
systems-assistant
bot
requested review from
dayatsin-amd and
fxkamd
as code owners
dayatsin-amd
approved these changes
Aug 12, 2025
jrmadsen
pushed a commit
that referenced
this pull request
Aug 12, 2025
* Manually search for rocdecode ad rocjpeg libraries * Update examples/jpegdecode/CMakeLists.txt Fix typo. Co-authored-by: David Galiffi <David.Galiffi@amd.com> --------- Co-authored-by: David Galiffi <David.Galiffi@amd.com> [ROCm/rocprofiler-systems commit: f4e9846]
Sundance636
deleted the
import/develop/ROCm_ROCR-Runtime/sclement_SWDEV-548802
branch
systems-assistant bot
added a commit
to ROCm/ROCR-Runtime
that referenced
this pull request
Aug 14, 2025
Previously regardless of hsa_agent passed the prefetch is always driven to node 0, now the agent of interest may be properly prefetched. Signed-off-by: Sunday Clement <Sunday.Clement@amd.com> Co-authored-by: Sunday Clement <Sunday.Clement@amd.com> Co-authored-by: systems-assistant[bot] <systems-assistant[bot]@users.noreply.github.com> [rocm-systems] ROCm/rocm-systems#294 (commit 3fd8af5)
systems-assistant bot
pushed a commit
that referenced
this pull request
Aug 18, 2025
Co-authored-by: Rahul Manocha <rmanocha@amd.com>
jayhawk-commits
pushed a commit
that referenced
this pull request
Aug 18, 2025
Co-authored-by: Rahul Manocha <rmanocha@amd.com> [ROCm/hip commit: fb19412]
jharryma
pushed a commit
that referenced
this pull request
Sep 12, 2025
* Manually search for rocdecode ad rocjpeg libraries * Update examples/jpegdecode/CMakeLists.txt Fix typo. Co-authored-by: David Galiffi <David.Galiffi@amd.com> --------- Co-authored-by: David Galiffi <David.Galiffi@amd.com>
ammallya
pushed a commit
that referenced
this pull request
Jan 21, 2026
somehow the test whether we requested MPI support or not stopped working, although no obvious code change can be located. Make the if-statement more stringent by explicitely testing whether USE_MPI_SUPPORT is "ON".
ammallya
pushed a commit
that referenced
this pull request
Jan 21, 2026
somehow the test whether we requested MPI support or not stopped working, although no obvious code change can be located. Make the if-statement more stringent by explicitely testing whether USE_MPI_SUPPORT is "ON". [ROCm/rocshmem commit: c0285ac]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously regardless of hsa_agent passed the prefetch is always driven to node 0, now the agent of interest may be properly prefetched.
🔁 Imported from ROCm/ROCR-Runtime#349
🧑💻 Originally authored by @rocm-devops