Skip to content

fix(hipsparselt) Add CTests for FFM and merge SPMM into other tests#8750

Open
leowu2017 wants to merge 2 commits into
developfrom
users/leowu/rocm-20727
Open

fix(hipsparselt) Add CTests for FFM and merge SPMM into other tests#8750
leowu2017 wants to merge 2 commits into
developfrom
users/leowu/rocm-20727

Conversation

@leowu2017

@leowu2017 leowu2017 commented Jun 24, 2026 •
edited by atlassian Bot
Loading

Copy link
Copy Markdown
Contributor

ROCM-20727

Motivation

TheRock CI has changed the ctest matching rule from substring to exact match. Therefore, test_categories.yaml needs to be updated accordingly to ensure consistent behavior.

Technical Details

  1. Combine SPMM and other tests, and keep the same timeout.
  2. Add tests for FFM (ffm_quick, ffm_full), each with a 2-hour timeout.

Test Plan

The tests are triggered as expected.

Test Result

image

Submission Checklist

JIRA ID : ROCM-20727

@leowu2017 leowu2017 requested a review from a team as a code owner June 24, 2026 04:04
@leowu2017 leowu2017 force-pushed the users/leowu/rocm-20727 branch 2 times, most recently from f833716 to 9290f79 Compare June 24, 2026 04:46
@leowu2017 leowu2017 changed the title Add CTests for FFM and merge SPMM into other tests [HipSparseLt] Add CTests for FFM and merge SPMM into other tests Jun 24, 2026
vin-huang
vin-huang approved these changes Jun 24, 2026
View reviewed changes

@vin-huang vin-huang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@leowu2017 leowu2017 force-pushed the users/leowu/rocm-20727 branch from 9290f79 to 6ee1e69 Compare June 29, 2026 02:08
@therock-pr-bot

therock-pr-bot Bot commented Jun 29, 2026 •
edited
Loading

Copy link
Copy Markdown

❌ PR Check — Action Required

Check Status Details
🌿 Branch Name ✅ Pass —
📝 PR Title/Description ❌ Fail Error: Title does not follow Conventional Commits style.
Expected: start with a valid type (feat, fix, docs, …).
Desired format: type(optional-scope): short description
⛔ Forbidden Files ✅ Pass —
🧪 Unit Test ✅ Pass PR does not contain code files — Unit Test auto-passed
🔎 pre-commit ✅ Pass —
🚫 Draft PR 🔜 To Be Enabled —
🚩 Feature Flag 🔜 To Be Enabled —
📊 Code Coverage 🔜 To Be Enabled —

⚠️ 1 policy check(s) failed. Please address the issues above before this PR can be Reviewed.

🚫 Please fix the failed policies

  • ❌ PR Title/Description

The Not ready to Review label was added to this PR. Once all policies pass, the label is removed automatically.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

@therock-pr-bot

therock-pr-bot Bot commented Jun 29, 2026

Copy link
Copy Markdown

🚫 Please fix the failed policies before requesting reviews.

The following policy checks failed:

  • ❌ PR Title/Description

The Not ready to Review label has been added to this PR.
Once all policies pass, the label will be removed automatically.

@leowu2017 leowu2017 changed the title [HipSparseLt] Add CTests for FFM and merge SPMM into other tests fix: [HipSparseLt] Add CTests for FFM and merge SPMM into other tests Jun 29, 2026
@leowu2017 leowu2017 changed the title fix: [HipSparseLt] Add CTests for FFM and merge SPMM into other tests fix(hipsparselt) Add CTests for FFM and merge SPMM into other tests Jun 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vin-huang vin-huang vin-huang approved these changes

Assignees

No one assigned

Labels

organization: ROCm project: hipsparselt

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@leowu2017 @vin-huang