Skip to content

chore(rocrand): removal of host device attributes#8806

Merged
umfranzw merged 2 commits into
developfrom
users/borysborys/chore-rocrand-removal-host-device-attributes-on-deduction-guide
Jul 18, 2026
Merged

chore(rocrand): removal of host device attributes#8806
umfranzw merged 2 commits into
developfrom
users/borysborys/chore-rocrand-removal-host-device-attributes-on-deduction-guide

Conversation

@Naraenda

@Naraenda Naraenda commented Jun 25, 2026

Copy link
Copy Markdown
Member

Motivation

Removal of host device attributes from a deduction guide

ISSUE ID: #3123.

Technical Details

Resolved as proposed.

Submission Checklist

Fixed by @borysborys.

@Naraenda Naraenda self-assigned this Jun 25, 2026
@Naraenda
Naraenda requested a review from a team as a code owner June 25, 2026 11:42
@assistant-librarian assistant-librarian Bot added the organization: streamhpc contributors from streamhpc label Jun 25, 2026
@codecov-commenter

codecov-commenter commented Jun 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

❌ Your project status has failed because the head coverage (76.84%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #8806   +/-   ##
========================================
  Coverage    63.99%   63.99%           
========================================
  Files         2757     2757           
  Lines       449481   449482    +1     
  Branches     66131    66131           
========================================
+ Hits        287603   287604    +1     
  Misses      140609   140609           
  Partials     21269    21269           
Flag Coverage Δ *Carryforward flag
TensileLite 34.34% <ø> (ø) Carriedforward from e67ac38
TensileLite-CPP 38.19% <ø> (ø) Carriedforward from e67ac38
TensileLite-Unit 35.37% <ø> (ø) Carriedforward from e67ac38
hipBLAS 90.81% <ø> (ø) Carriedforward from e67ac38
hipBLASLt 34.63% <ø> (ø) Carriedforward from e67ac38
hipCUB 82.68% <ø> (ø) Carriedforward from e67ac38
hipDNN 86.20% <ø> (ø) Carriedforward from e67ac38
hipFFT 50.88% <ø> (ø) Carriedforward from e67ac38
hipRAND 76.12% <ø> (ø) Carriedforward from e67ac38
hipSOLVER 69.18% <ø> (ø) Carriedforward from e67ac38
hipSPARSE 86.27% <ø> (ø) Carriedforward from e67ac38
rocBLAS 47.95% <ø> (ø) Carriedforward from e67ac38
rocFFT 46.93% <ø> (ø) Carriedforward from e67ac38
rocRAND 57.03% <100.00%> (+0.01%) ⬆️
rocSOLVER 76.84% <ø> (ø) Carriedforward from e67ac38
rocSPARSE 72.40% <ø> (ø) Carriedforward from e67ac38
rocThrust 91.36% <ø> (ø) Carriedforward from e67ac38

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
projects/rocrand/library/src/rng/threefry.hpp 79.30% <100.00%> (ø)
...ojects/rocrand/library/src/rng/utils/cpp_utils.hpp 64.71% <100.00%> (+0.71%) ⬆️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Naraenda

Copy link
Copy Markdown
Member Author

@stanleytsang-amd Can this be merged? CI is throwing up a few warnings on 7.14 without it.

@therock-pr-bot

therock-pr-bot Bot commented Jul 17, 2026

Copy link
Copy Markdown

❌ PR Check — Action Required

Check Status Details
🌿 Branch Name ✅ Pass
📝 PR Title/Description ✅ Pass
Forbidden Files ✅ Pass
🧪 Unit Test ❌ Fail Error: Source/code files changed without an accompanying unit test.
Expected: add at least one test file named like test_<name>.py / test_<name>.cpp (or <name>_test.*).
Current: code file(s) changed: projects/rocrand/library/src/rng/threefry.hpp, projects/rocrand/library/src/rng/utils/cpp_utils.hpp; no test file found
🔎 pre-commit ✅ Pass
🚫 Draft PR 🔜 To Be Enabled
🚩 Feature Flag 🔜 To Be Enabled
📊 Code Coverage 🔜 To Be Enabled

⚠️ 1 policy check(s) failed. Please address the issues above before this PR can be Reviewed.

🚫 Please fix the failed policies

  • ❌ Unit Test

The Not ready to Review label was added to this PR. Once all policies pass, the label is removed automatically.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

@therock-pr-bot

therock-pr-bot Bot commented Jul 17, 2026

Copy link
Copy Markdown

🚫 Please fix the failed policies before requesting reviews.

The following policy checks failed:

  • ❌ Unit Test

The Not ready to Review label has been added to this PR.
Once all policies pass, the label will be removed automatically.

@NguyenNhuDi NguyenNhuDi changed the title chore(rocRAND): removal of host device attributes from a deduction guide fix(rocRAND): removal of host device attributes Jul 17, 2026
@NguyenNhuDi NguyenNhuDi changed the title fix(rocRAND): removal of host device attributes fix(rocrand): removal of host device attributes Jul 17, 2026
@NguyenNhuDi NguyenNhuDi changed the title fix(rocrand): removal of host device attributes chore(rocrand): removal of host device attributes Jul 17, 2026
@NguyenNhuDi
NguyenNhuDi enabled auto-merge (squash) July 17, 2026 16:00
@NguyenNhuDi
NguyenNhuDi disabled auto-merge July 17, 2026 16:00
@umfranzw

Copy link
Copy Markdown
Contributor

Our CI was failing with some complaints about the formatting in a few files. I've pushed a new commit that makes the changes it was requesting.

@umfranzw
umfranzw force-pushed the users/borysborys/chore-rocrand-removal-host-device-attributes-on-deduction-guide branch from 54d91e0 to fd37157 Compare July 17, 2026 19:48
@umfranzw
umfranzw merged commit 3a1d60c into develop Jul 18, 2026
26 of 27 checks passed
@umfranzw
umfranzw deleted the users/borysborys/chore-rocrand-removal-host-device-attributes-on-deduction-guide branch July 18, 2026 02:06
assistant-librarian Bot pushed a commit to ROCm/rocRAND that referenced this pull request Jul 18, 2026
chore(rocrand): removal of host device attributes

## Motivation
Removal of host device attributes from a deduction guide

ISSUE ID: ROCm/rocm-libraries#3123.

## Technical Details

Resolved as proposed.

## Submission Checklist

- [x] Look over the contributing guidelines at
https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.

Fixed by @borysborys.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants