Skip to content
This repository was archived by the owner on Jan 26, 2024. It is now read-only.
This repository was archived by the owner on Jan 26, 2024. It is now read-only.

Possible bug in occupancy calculation #58

@jpsamaroo

Description

@jpsamaroo

I've been porting the algorithm in ihipOccupancyMaxActiveBlocksPerMultiprocessor to Julia to use for our own occupancy calculations, and noticed a potential typo in:

https://github.com/ROCm-Developer-Tools/hipamd/blob/05e3016405bdaec0b8acfe8378df968dd02136d5/src/hip_platform.cpp#L351

I assume this should actually be if (wrkGrpInfo->usedVGPRs_ > 0) {, since we want to ensure we don't get a divide-by-zero when no VGPRs are used? Obviously such kernels probably don't actually need their occupancy calculated, but I figured it was worth reporting in case someone has run into this!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions