Skip to content
This repository was archived by the owner on Jan 26, 2024. It is now read-only.
This repository was archived by the owner on Jan 26, 2024. It is now read-only.

CMAKE_INSTALL_<dir> paths assumed to be relative #55

@Madouura

Description

@Madouura

This causes problems for distributions which may use different paths.
See: NixOS/nixpkgs#197838 (comment)
I have also noticed this to be an issue across most ROCm packages, (rocsparse, hipsparse, etc) in which manual CMAKE_INSTALL_<dir> variables must be set on the package maintainer's side.

Suggested fix: Use CMAKE_INSTALL_FULL_<dir> for absolute paths instead.
In what I've noticed particularly in rocsparse first, the current method ends up making <path>/rocsparse/<path>, in hip it creates invalid symlinks. (On NixOS, where package roots are in /nix/store/<package> and not /)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions