SWDEV-537865 - Don't return zero for platforms with only a single CU #477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can occur on platforms that operates in WGP (work group processor) mode in which the CUs are grouped in pairs so there are effectively half as many multiprocessing units.
12 tasks
Contributor
|
Imported to ROCm/rocm-systems#625 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can occur on platforms that operates in WGP (work group processor) mode in which the CUs are grouped in pairs so there are effectively half as many multiprocessing units.
Associated JIRA ticket number/Github issue number
Fixes SWDEV-537865
What type of PR is this? (check all applicable)
What were the changes?
Clamp the results from
GenerateThreadDimensions,GenerateBlockDimensions,GenerateThreadDimensionsForShuffleandGenerateBlockDimensionsForShuffleto prevent invalid zero values whenmultiProcessorCountreturns 1.Why are these changes needed?
Fixes divide by zero errors and invalid parameter errors.
Updated CHANGELOG?
Added/Updated documentation?
Additional Checks