Skip to content

[Issue] PR bot is rejecting valid github issue references #6120

Description

@ScottTodd

Continuing from #5994 (comment)

References like #1234 and https://github.com/ROCm/TheRock/issues/1234 should satisfy the "issue reference patterns" here:

# A PR must reference a JIRA ID or ISSUE ID (a key, number, or link).
# The separator is OPTIONAL and may be ':' or '-'. Either field accepts:
# a JIRA key (PREFIX-<number>), a number (with or without '#'), or a link.
# Any JIRA project key is accepted — not just one project.
# Valid examples:
# JIRA ID : AITESTAUTO-6039
# JIRA ID - #330
# JIRA ID #330
# ISSUE ID : AITESTUTO-3334
# ISSUE ID - AITESTAUTO-3433
# ISSUE ID : https://github.com/ROCm/TheRock-Infra/issues/1234
issue_reference_patterns:
- '(?im)^\s*JIRA\s*ID\s*[:\-]?\s*(#?\d+|[A-Z][A-Z0-9]+-\d+|https?:\/\/\S+)'
- '(?im)^\s*ISSUE\s*ID\s*[:\-]?\s*(#?\d+|[A-Z][A-Z0-9]+-\d+|https?:\/\/\S+)'

We should be encouraging https://docs.github.com/en/issues/tracking-your-work-with-issues/using-issues/linking-a-pull-request-to-an-issue , not something custom that is leading to PR authors writing both:

ISSUE ID https://github.com/ROCm/TheRock/issues/6061
Closes https://github.com/ROCm/TheRock/issues/6061

I think we should also be able to relax the JIRA ID pattern to just ALLCAPSCOMPONENT-1234 for most cases. Maybe we have some non-standard components / project key formats though? See https://confluence.atlassian.com/adminjiraserver/changing-the-project-key-format-938847081.html

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type
No fields configured for issues without a type.

Projects

Status
TODO

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions