[Issue] ROCDXG skips uploads on fork PRs leading to rocm-sdk test `no match for pattern 'librocdxg*.so*'` failures

[ScottTodd]

Seeing this on a few of my PRs, all created from forks...? I haven't seen any failures on the default branch or other PRs yet so I'm not sure if this is unique to the specific runners or some files that are missing due to fork PRs having different access 🤔

Example: https://github.com/ROCm/TheRock/actions/runs/28051028398/job/83064423105?pr=6071

Run rocm-sdk test
testCLI (rocm_sdk.tests.base_test.ROCmBaseTest.testCLI) ... ++ Exec [/__w/TheRock/TheRock]$ /__w/TheRock/TheRock/.venv/bin/python -m rocm_sdk --help
ok
testTargets (rocm_sdk.tests.base_test.ROCmBaseTest.testTargets) ... ++ Exec [/__w/TheRock/TheRock]$ /__w/TheRock/TheRock/.venv/bin/python -m rocm_sdk targets
ok
testVersion (rocm_sdk.tests.base_test.ROCmBaseTest.testVersion) ... ++ Exec [/__w/TheRock/TheRock]$ /__w/TheRock/TheRock/.venv/bin/python -m rocm_sdk version
ok
test_initialize_process_check_version (rocm_sdk.tests.base_test.ROCmBaseTest.test_initialize_process_check_version) ... ok
test_initialize_process_check_version_asterisk (rocm_sdk.tests.base_test.ROCmBaseTest.test_initialize_process_check_version_asterisk) ... ok
test_initialize_process_check_version_mismatch (rocm_sdk.tests.base_test.ROCmBaseTest.test_initialize_process_check_version_mismatch) ... ok
test_initialize_process_check_version_mismatch_warning (rocm_sdk.tests.base_test.ROCmBaseTest.test_initialize_process_check_version_mismatch_warning) ... ok
test_initialize_process_check_version_pattern (rocm_sdk.tests.base_test.ROCmBaseTest.test_initialize_process_check_version_pattern) ... ok
test_initialize_process_env_preload_1 (rocm_sdk.tests.base_test.ROCmBaseTest.test_initialize_process_env_preload_1) ... ok
test_initialize_process_env_preload_2_comma (rocm_sdk.tests.base_test.ROCmBaseTest.test_initialize_process_env_preload_2_comma) ... ok
test_initialize_process_env_preload_2_semi (rocm_sdk.tests.base_test.ROCmBaseTest.test_initialize_process_env_preload_2_semi) ... ok
test_initialize_process_preload_libraries (rocm_sdk.tests.base_test.ROCmBaseTest.test_initialize_process_preload_libraries) ... ok
testConsoleScripts (rocm_sdk.tests.core_test.ROCmCoreTest.testConsoleScripts) ... ok
testInstallationLayout (rocm_sdk.tests.core_test.ROCmCoreTest.testInstallationLayout)
The `rocm_sdk` and core module must be siblings on disk. ... ok
testPreloadLibraries (rocm_sdk.tests.core_test.ROCmCoreTest.testPreloadLibraries) ... 
  testPreloadLibraries (rocm_sdk.tests.core_test.ROCmCoreTest.testPreloadLibraries) [Check rocm_sdk.preload_libraries] (shortname='rocdxg') ... ERROR
testSharedLibrariesLoad (rocm_sdk.tests.core_test.ROCmCoreTest.testSharedLibrariesLoad) ... ok
testConsoleScripts (rocm_sdk.tests.libraries_test.ROCmLibrariesTest.testConsoleScripts) ... ok
testInstallationLayout (rocm_sdk.tests.libraries_test.ROCmLibrariesTest.testInstallationLayout)
The `rocm_sdk` and libraries module must be siblings on disk. ... ok
testSharedLibrariesLoad (rocm_sdk.tests.libraries_test.ROCmLibrariesTest.testSharedLibrariesLoad) ... ok

======================================================================
ERROR: testPreloadLibraries (rocm_sdk.tests.core_test.ROCmCoreTest.testPreloadLibraries) [Check rocm_sdk.preload_libraries] (shortname='rocdxg')
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/__w/TheRock/TheRock/.venv/lib64/python3.12/site-packages/rocm_sdk/tests/core_test.py", line 161, in testPreloadLibraries
    rocm_sdk.preload_libraries(lib_entry.shortname)
  File "/__w/TheRock/TheRock/.venv/lib64/python3.12/site-packages/rocm_sdk/__init__.py", line 100, in preload_libraries
    paths = find_libraries(*shortnames)
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/__w/TheRock/TheRock/.venv/lib64/python3.12/site-packages/rocm_sdk/__init__.py", line 64, in find_libraries
    raise FileNotFoundError(
FileNotFoundError: Could not find rocm library 'rocdxg' at path '/__w/TheRock/TheRock/.venv/lib64/python3.12/site-packages/_rocm_sdk_core/lib,' no match for pattern 'librocdxg*.so*'

----------------------------------------------------------------------
Ran 19 tests in 5.985s

FAILED (errors=1)
Error: Process completed with exit code 1.

Other instances:

• https://github.com/ROCm/TheRock/actions/runs/27986329848/job/82846434529?pr=5729
• https://github.com/ROCm/TheRock/actions/runs/27979792756/job/83009827874?pr=6043

I tried to reproduce with direct workflow_dispatch of the test wheels workflow but the jobs succeeded:

• https://github.com/ROCm/TheRock/actions/runs/28038895243
• https://github.com/ROCm/TheRock/actions/runs/28041970603

[ScottTodd]

🤦 oh, that's why it's not working. Artifact upload for ROCDXG is skipped for forks right now:

TheRock/.github/workflows/multi_arch_build_wsl_rocdxg_artifacts.yml

Lines 236 to 264 in a5f626b

	- name: Configure AWS credentials for artifact uploads
	if: ${{ always() && !(github.event_name == 'pull_request' && github.event.pull_request.head.repo.fork) }}
	uses: ./.github/actions/configure_aws_artifacts_credentials
	with:
	release_type: ${{ inputs.release_type }}
	- name: Push stage artifacts
	if: ${{ !(github.event_name == 'pull_request' && github.event.pull_request.head.repo.fork) }}
	shell: wsl-bash {0}
	env:
	WSLENV: THEROCK_HOST_WORKSPACE/p:THEROCK_HOST_BUILD_DIR/p:GITHUB_REPOSITORY:GITHUB_EVENT_NAME:GITHUB_EVENT_PATH/p:RELEASE_TYPE:AWS_ACCESS_KEY_ID:AWS_SECRET_ACCESS_KEY:AWS_SESSION_TOKEN:AWS_DEFAULT_REGION:AWS_REGION
	run: |
	stage_name="${{ inputs.stage_name }}"
	wsl_venv_dir="${HOME}/therock-wsl-rocdxg/.venv"
	"${wsl_venv_dir}/bin/python" "${THEROCK_HOST_WORKSPACE}/build_tools/artifact_manager.py" push --run-id ${{ github.run_id }} \
	--run-github-repo="${{ github.repository }}" \
	--platform linux \
	--stage="${stage_name}" \
	--build-dir="${THEROCK_HOST_BUILD_DIR}"
	- name: Upload stage logs
	if: ${{ always() && !(github.event_name == 'pull_request' && github.event.pull_request.head.repo.fork) }}
	run: |
	python build_tools/github_actions/post_stage_upload.py \
	--run-id=${{ github.run_id }} \
	--platform=linux \
	--stage="${STAGE_NAME}" \
	--build-dir="${THEROCK_HOST_BUILD_DIR}" \
	--amdgpu-family=""

See #5378

Keep WSL ROCDXG build validation enabled for fork PRs, but skip
S3 artifact and log uploads from forks until a fork-safe credential
path is available for the WSL Windows runner.

[ScottTodd]

We just started seeing this recently since #5283 added this code to build_tools/packaging/python/templates/rocm/src/rocm_sdk/_dist_info.py:

LibraryEntry("rocdxg", "core", "librocdxg*.so*", "")