Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upkeep: clean up add_green_technologies_to_abcd() #497

Open
jacobvjk opened this issue May 7, 2024 · 0 comments
Open

upkeep: clean up add_green_technologies_to_abcd() #497

jacobvjk opened this issue May 7, 2024 · 0 comments
Assignees
Labels
upkeep maintenance, infrastructure, and similar

Comments

@jacobvjk
Copy link
Member

jacobvjk commented May 7, 2024

green_rows_to_add <- data %>%

  • green_rows_to_add() uses a summarize call to obtain the distinct rows of the abcd, using dplyr::distinct is more appropriate
  • following this, a left_join is used to expand the abcd by missing low carbon technologies. this adds rows with NA values for all technologies that are not missing. There does not seem to be a reason for that, so an inner_join would be more adequate.
@jacobvjk jacobvjk added the upkeep maintenance, infrastructure, and similar label May 7, 2024
@jacobvjk jacobvjk self-assigned this May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upkeep maintenance, infrastructure, and similar
Projects
None yet
Development

No branches or pull requests

1 participant