Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: sector_view.svelte probably should not have scenario names hard-coded in selector layout #30

Closed
jdhoffa opened this issue Aug 19, 2024 · 3 comments
Closed

feat: sector_view.svelte probably should not have scenario names hard-coded in selector layout #30

jdhoffa opened this issue Aug 19, 2024 · 3 comments

Comments

@jdhoffa
Copy link
Member

jdhoffa commented Aug 19, 2024 

          NB: I wonder if it's possible to generate these selectors programmatically. As it stands, the dashboard would only work for 2023 data, and not be generalizable to different years which is not ideal.

Originally posted by @jdhoffa in #28 (comment)
@MonikaFu
Copy link
Contributor

Agreed and this will also apply to other selectors actually. They all should be data-driven and not hard-coded I think.

@MonikaFu
Copy link
Contributor

ADO: https://dev.azure.com/RMI-PACTA/2DegreesInvesting/_sprints/taskboard/P4I/2DegreesInvesting/2024_17?workitem=11679

@jdhoffa jdhoffa mentioned this issue Aug 19, 2024
Merged
@MonikaFu MonikaFu mentioned this issue Oct 18, 2024
Merged
@MonikaFu
Copy link
Contributor

closed with #44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jdhoffa @MonikaFu