add support for a custom user data dir #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* as a new argument in Chrome$new() * add some tests * new helper function to deactivate verbose in test : without_verbose()
|
awesome! ty :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will close #90
Current implementation is using a new argument in
Chrome$new().Another choice would be to detect if a
--user-data-diris passed inextra_argsand deactivate the creation of new work dir by crrri. Would be oriented toward a more advanced usage.If provided in
user_data_dir, the folder won't be deleted by crrri at the end. A message warn the user (but is inside a promise so print in a weirdly timing)@yonicd, using this PR will help to test with a custom user data dir.
@RLesur what do you think ? Should we test and improve some usage ?
I know it works well in headful mode, but not sure to check in headless mode as
chrome://versionurl does not work in headless mode.