Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CleanRL example bug? #23

Open
samlobel opened this issue Oct 14, 2024 · 2 comments
Open

CleanRL example bug? #23

samlobel opened this issue Oct 14, 2024 · 2 comments

Comments

@samlobel
Copy link
Contributor

Hi all,

Getting started with the rlexplore_with_cleanrl.py example and I think there's an important typo, introduced here (line 254).

The first block, which overwrites next_obs as returned by the environment, shouldn't be there. It's throwing a shape error because line 256 is trying to put an array of shape (128, 8, 4, 84, 84) into a slot of shape (8, 4, 84, 84).

"real_next_obs" is the one that's used, and that one looks right, except that the next_obs referenced there should be the environment's next_obs, not the one modified above.

Thanks!
Sam

@yuanmingqi
Copy link
Collaborator

Hi Sam, I just updated the code and marked u as a co-author; see if it works now. Thanks!

@samlobel
Copy link
Contributor Author

Sorry for the late response -- success! Works now, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants