feat(cursors): compute chore impl

Author: Varixo

packages/qwik/src/core/internal.ts

@@ -33,7 +33,7 @@ export type { VirtualVNode as _VirtualVNode } from './shared/vnode/virtual-vnode
 export { _hasStoreEffects, isStore as _isStore } from './reactive-primitives/impl/store';
 export { _wrapProp, _wrapSignal } from './reactive-primitives/internal-api';
 export { SubscriptionData as _SubscriptionData } from './reactive-primitives/subscription-data';
-export { _EFFECT_BACK_REF } from './reactive-primitives/types';
+export { _EFFECT_BACK_REF } from './reactive-primitives/backref';
 export {
   isStringifiable as _isStringifiable,
   type Stringifiable as _Stringifiable,

packages/qwik/src/core/reactive-primitives/impl/wrapped-signal-impl.ts

@@ -2,7 +2,7 @@ import { vnode_setProp } from '../../client/vnode';
 import { assertFalse } from '../../shared/error/assert';
 import { QError, qError } from '../../shared/error/error';
 import type { Container, HostElement } from '../../shared/types';
-import { HOST_EFFECTS } from '../../shared/utils/markers';
+import { HOST_SIGNAL } from '../../shared/utils/markers';
 import { ChoreBits } from '../../shared/vnode/enums/chore-bits.enum';
 import { trackSignal } from '../../use/use-core';
 import { getValueProp } from '../internal-api';
@@ -46,7 +46,7 @@ export class WrappedSignalImpl<T> extends SignalImpl<T> implements BackRef {
       this.$computeIfNeeded$();
     } catch (_) {
       if (this.$container$ && this.$hostElement$) {
-        vnode_setProp(this.$hostElement$, HOST_EFFECTS, this.$effects$);
+        vnode_setProp(this.$hostElement$, HOST_SIGNAL, this);
         markVNodeDirty(this.$container$, this.$hostElement$, ChoreBits.COMPUTE);
       }
     }
@@ -64,7 +64,7 @@ export class WrappedSignalImpl<T> extends SignalImpl<T> implements BackRef {
   force() {
     this.$flags$ |= SignalFlags.RUN_EFFECTS;
     if (this.$container$ && this.$hostElement$) {
-      vnode_setProp(this.$hostElement$, HOST_EFFECTS, this.$effects$);
+      vnode_setProp(this.$hostElement$, HOST_SIGNAL, this);
       markVNodeDirty(this.$container$, this.$hostElement$, ChoreBits.COMPUTE);
     }
   }

packages/qwik/src/core/shared/cursor/chore-execution.ts

@@ -16,23 +16,27 @@ import {
   QScopedStyle,
   NODE_PROPS_DATA_KEY,
   NODE_DIFF_DATA_KEY,
+  HOST_SIGNAL,
 } from '../utils/markers';
 import { addComponentStylePrefix } from '../utils/scoped-styles';
-import { isPromise, retryOnPromise, safeCall } from '../utils/promises';
+import { isPromise, maybeThen, retryOnPromise, safeCall } from '../utils/promises';
 import type { ValueOrPromise } from '../utils/types';
 import type { Container, HostElement } from '../types';
 import type { VNode } from '../vnode/vnode';
 import { VNodeFlags, type ClientContainer } from '../../client/types';
 import type { Cursor } from './cursor';
 import type { NodeProp } from '../../reactive-primitives/subscription-data';
-import { isSignal } from '../../reactive-primitives/utils';
+import { isSignal, scheduleEffects } from '../../reactive-primitives/utils';
 import type { Signal } from '../../reactive-primitives/signal.public';
 import { serializeAttribute } from '../utils/styles';
 import type { ISsrNode, SSRContainer } from '../../ssr/ssr-types';
 import type { ElementVNode } from '../vnode/element-vnode';
 import { VNodeOperationType } from '../vnode/enums/vnode-operation-type.enum';
 import type { JSXOutput } from '../jsx/types/jsx-node';
 import { getAfterFlushTasks, setAfterFlushTasks, setExtraPromises } from './cursor-props';
+import { invoke, newInvokeContext } from '../../use/use-core';
+import type { WrappedSignalImpl } from '../../reactive-primitives/impl/wrapped-signal-impl';
+import { SignalFlags } from '../../reactive-primitives/types';
 
 /**
  * Executes tasks for a vNode if the TASKS dirty bit is set. Tasks are stored in the ELEMENT_SEQ
@@ -337,11 +341,24 @@ export function executeCleanup(vNode: VNode, container: Container): void {
  */
 export function executeCompute(vNode: VNode, container: Container): ValueOrPromise<void> {
   vNode.dirty &= ~ChoreBits.COMPUTE;
-
-  // Compute chores are typically handled by the reactive system.
-  // This is a placeholder for explicit compute chores if needed.
-
-  // TODO remove or use
-
-  return;
+  const target = container.getHostProp<WrappedSignalImpl<unknown> | null>(vNode, HOST_SIGNAL);
+  if (!target) {
+    return;
+  }
+  const effects = target.$effects$;
+
+  const ctx = newInvokeContext();
+  ctx.$container$ = container;
+  // needed for computed signals and throwing QRLs
+  return maybeThen(
+    retryOnPromise(() =>
+      invoke.call(target, ctx, (target as WrappedSignalImpl<unknown>).$computeIfNeeded$)
+    ),
+    () => {
+      if ((target as WrappedSignalImpl<unknown>).$flags$ & SignalFlags.RUN_EFFECTS) {
+        (target as WrappedSignalImpl<unknown>).$flags$ &= ~SignalFlags.RUN_EFFECTS;
+        return scheduleEffects(container, target, effects);
+      }
+    }
+  );
 }

packages/qwik/src/core/shared/cursor/cursor-props.ts

@@ -103,7 +103,7 @@ function mergeCursors(container: Container, newCursor: VNode, oldCursor: VNode):
   resolveCursor(container);
   // merge after flush tasks
   const oldAfterFlushTasks = getAfterFlushTasks(oldCursor);
-  if (oldAfterFlushTasks) {
+  if (oldAfterFlushTasks && oldAfterFlushTasks.length > 0) {
     const newAfterFlushTasks = getAfterFlushTasks(newCursor);
     if (newAfterFlushTasks) {
       newAfterFlushTasks.push(...oldAfterFlushTasks);
@@ -113,7 +113,7 @@ function mergeCursors(container: Container, newCursor: VNode, oldCursor: VNode):
   }
   // merge extra promises
   const oldExtraPromises = getExtraPromises(oldCursor);
-  if (oldExtraPromises) {
+  if (oldExtraPromises && oldExtraPromises.length > 0) {
     const newExtraPromises = getExtraPromises(newCursor);
     if (newExtraPromises) {
       newExtraPromises.push(...oldExtraPromises);
@@ -123,7 +123,7 @@ function mergeCursors(container: Container, newCursor: VNode, oldCursor: VNode):
   }
   // merge journal
   const oldJournal = getCursorJournal(oldCursor);
-  if (oldJournal) {
+  if (oldJournal && oldJournal.length > 0) {
     const newJournal = getCursorJournal(newCursor);
     if (newJournal) {
       newJournal.push(...oldJournal);

packages/qwik/src/core/shared/utils/markers.ts

@@ -84,7 +84,7 @@ export const ELEMENT_BACKPATCH_DATA = 'qwik/backpatch';
 /** Key used to store pending node prop updates in vNode props. */
 export const NODE_PROPS_DATA_KEY = 'q:nodeProps';
 export const NODE_DIFF_DATA_KEY = 'q:nodeDiff';
-export const HOST_EFFECTS = 'q:effects';
+export const HOST_SIGNAL = 'q:signal';
 export const Q_PREFIX = 'q:';
 
 /** Non serializable markers - always begins with `:` character */