feat: autofix packages-without-package-json (#31)

Author: QuiiBz

src/collect.rs

@@ -50,7 +50,7 @@ pub fn collect_packages(args: &Args) -> Result<PackagesList> {
         |packages_issues: &mut Vec<BoxIssue>, path: PathBuf| match Package::new(path.clone()) {
             Ok(package) => packages.push(package),
             Err(error) => {
-                if error.to_string().contains("package.json") {
+                if error.to_string().contains("not found") {
                     packages_issues.push(PackagesWithoutPackageJsonIssue::new(
                         path.to_string_lossy().to_string(),
                     ));
@@ -170,8 +170,10 @@ pub fn collect_issues(args: &Args, packages_list: PackagesList) -> IssuesList<'_
     let mut all_dependencies = IndexMap::new();
 
     for package in packages {
-        if args.ignore_package.contains(package.get_name()) {
-            continue;
+        if let Some(package_name) = package.get_name() {
+            if args.ignore_package.contains(package_name) {
+                continue;
+            }
         }
 
         let package_type = PackageType::Package(package.get_path());
@@ -402,7 +404,7 @@ mod test {
 
         let mut packages = packages
             .into_iter()
-            .map(|package| package.get_name().to_string())
+            .map(|package| package.get_name().clone().unwrap().to_string())
             .collect::<Vec<_>>();
         packages.sort();
 

src/packages/mod.rs

@@ -19,7 +19,7 @@ pub struct PackagesList {
 
 #[derive(Deserialize, Debug)]
 struct PackageInner {
-    name: String,
+    name: Option<String>,
     private: Option<bool>,
     workspaces: Option<Vec<String>>,
     dependencies: Option<IndexMap<String, String>>,
@@ -61,7 +61,7 @@ impl Package {
         })
     }
 
-    pub fn get_name(&self) -> &String {
+    pub fn get_name(&self) -> &Option<String> {
         &self.inner.name
     }
 

src/packages/root.rs

@@ -18,8 +18,8 @@ impl RootPackage {
     }
 
     #[cfg(test)]
-    pub fn get_name(&self) -> &String {
-        self.0.get_name()
+    pub fn get_name(&self) -> String {
+        self.0.get_name().clone().unwrap_or_default()
     }
 
     pub fn get_workspaces(&self) -> Option<Vec<String>> {

src/rules/packages_without_package_json.rs

@@ -1,14 +1,19 @@
-use super::{Issue, IssueLevel};
-use std::borrow::Cow;
+use super::{Issue, IssueLevel, PackageType};
+use anyhow::Result;
+use std::{borrow::Cow, fs, path::PathBuf};
 
 #[derive(Debug)]
 pub struct PackagesWithoutPackageJsonIssue {
     package: String,
+    fixed: bool,
 }
 
 impl PackagesWithoutPackageJsonIssue {
     pub fn new(package: String) -> Box<Self> {
-        Box::new(Self { package })
+        Box::new(Self {
+            package,
+            fixed: false,
+        })
     }
 }
 
@@ -18,7 +23,10 @@ impl Issue for PackagesWithoutPackageJsonIssue {
     }
 
     fn level(&self) -> IssueLevel {
-        IssueLevel::Warning
+        match self.fixed {
+            true => IssueLevel::Fixed,
+            false => IssueLevel::Warning,
+        }
     }
 
     fn message(&self) -> String {
@@ -28,6 +36,30 @@ impl Issue for PackagesWithoutPackageJsonIssue {
     fn why(&self) -> Cow<'static, str> {
         Cow::Borrowed("All packages matching the workspace should have a package.json file.")
     }
+
+    fn fix(&mut self, _package_type: &PackageType) -> Result<()> {
+        let path = PathBuf::from(&self.package).join("package.json");
+        let package_name = path
+            .parent()
+            .unwrap()
+            .file_name()
+            .unwrap()
+            .to_str()
+            .unwrap();
+
+        let value = serde_json::json!({
+            "name": package_name,
+            "version": "0.0.0",
+            "private": true,
+        });
+
+        let value = serde_json::to_string_pretty(&value)?;
+        fs::write(path, value)?;
+
+        self.fixed = true;
+
+        Ok(())
+    }
 }
 
 #[cfg(test)]

src/rules/root_package_private_field.rs

@@ -50,10 +50,10 @@ impl Issue for RootPackagePrivateFieldIssue {
             let value = fs::read_to_string(&path)?;
             let mut value = serde_json::from_str::<serde_json::Value>(&value)?;
 
-            value.as_object_mut().unwrap().insert(
-                "private".to_string(),
-                serde_json::Value::String("true".to_string()),
-            );
+            value
+                .as_object_mut()
+                .unwrap()
+                .insert("private".to_string(), serde_json::Value::Bool(true));
 
             let value = serde_json::to_string_pretty(&value)?;
             fs::write(path, value)?;