-
Notifications
You must be signed in to change notification settings - Fork 130
Align grace period sources across default checks and admin marking #720
Copy link
Copy link
Open
Labels
Stellar WaveIssues in the Stellar wave programIssues in the Stellar wave programconfigurationAuto label for contract issues: configurationAuto label for contract issues: configurationdefaultsAuto label for contract issues: defaultsAuto label for contract issues: defaultspriority-mediumAuto label for contract issues: priority-mediumAuto label for contract issues: priority-mediumsmart-contractsAuto label for contract issues: smart-contractsAuto label for contract issues: smart-contractstestingAuto label for contract issues: testingAuto label for contract issues: testing
Description
Description
Unify optional grace overrides with stored protocol grace; add cross-endpoint tests.
Requirements and context
- Must be secure, tested, and documented
- Should be efficient and easy to review
- Align with existing Soroban contract patterns in
quicklendx-contracts
Suggested execution
- Fork the repo and create a branch
git checkout -b feature/grace-period-source-alignment- Implement changes
- Write contract:
src/defaults.rs,src/lib.rs - Write comprehensive tests:
src/test_default.rs - Add documentation:
docs/contracts/default-handling.md - Include NatSpec-style comments (Rust doc comments on public items)
- Validate security assumptions
Test and commit
- Run tests
- Cover edge cases
- Include test output and security notes
Example commit message
feat: align grace period across default APIs
Guidelines
- Minimum 95 percent test coverage
- Clear documentation
- Timeframe: 96 hours
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Stellar WaveIssues in the Stellar wave programIssues in the Stellar wave programconfigurationAuto label for contract issues: configurationAuto label for contract issues: configurationdefaultsAuto label for contract issues: defaultsAuto label for contract issues: defaultspriority-mediumAuto label for contract issues: priority-mediumAuto label for contract issues: priority-mediumsmart-contractsAuto label for contract issues: smart-contractsAuto label for contract issues: smart-contractstestingAuto label for contract issues: testingAuto label for contract issues: testing