-
Notifications
You must be signed in to change notification settings - Fork 130
Harden accept_bid_and_fund versus accept_bid state parity #705
Copy link
Copy link
Open
Labels
Stellar WaveIssues in the Stellar wave programIssues in the Stellar wave programbiddingDesign / UX backlog: biddingDesign / UX backlog: biddingescrowDesign / UX backlog: escrowDesign / UX backlog: escrowpriority-highAuto label for contract issues: priority-highAuto label for contract issues: priority-highsmart-contractsAuto label for contract issues: smart-contractsAuto label for contract issues: smart-contractstestingAuto label for contract issues: testingAuto label for contract issues: testing
Description
Description
Develop parity tests and documentation so funded-invoice paths behave consistently whether funding uses accept_bid_and_fund or accept_bid.
Requirements and context
- Must be secure, tested, and documented
- Should be efficient and easy to review
- Align with existing Soroban contract patterns in
quicklendx-contracts
Suggested execution
- Fork the repo and create a branch
git checkout -b feature/accept-bid-path-parity- Implement changes
- Write contract:
src/lib.rs - Write comprehensive tests:
src/test_escrow.rs,src/test_bid.rs - Add documentation:
docs/contracts/escrow.md - Include NatSpec-style comments (Rust doc comments on public items)
- Validate security assumptions
Test and commit
- Run tests
- Cover edge cases
- Include test output and security notes
Example commit message
feat: align accept_bid and accept_bid_and_fund behavior
Guidelines
- Minimum 95 percent test coverage
- Clear documentation
- Timeframe: 96 hours
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Stellar WaveIssues in the Stellar wave programIssues in the Stellar wave programbiddingDesign / UX backlog: biddingDesign / UX backlog: biddingescrowDesign / UX backlog: escrowDesign / UX backlog: escrowpriority-highAuto label for contract issues: priority-highAuto label for contract issues: priority-highsmart-contractsAuto label for contract issues: smart-contractsAuto label for contract issues: smart-contractstestingAuto label for contract issues: testingAuto label for contract issues: testing