Skip to content

Commit f52c57e

Browse files
authoredAug 14, 2018
Merge pull request #593 from norio-nomura/remove-fixme-sr-2290
Remove workaround to SR-2290
2 parents 3ec20ed + 94e6bb0 commit f52c57e

File tree

1 file changed

+0
-16
lines changed

1 file changed

+0
-16
lines changed
 

‎Sources/Nimble/Matchers/BeLogical.swift

-16
Original file line numberDiff line numberDiff line change
@@ -100,14 +100,6 @@ public func beTruthy<T: ExpressibleByBooleanLiteral & Equatable>() -> Predicate<
100100
return Predicate.simpleNilable("be truthy") { actualExpression in
101101
let actualValue = try actualExpression.evaluate()
102102
if let actualValue = actualValue {
103-
// FIXME: This is a workaround to SR-2290.
104-
// See:
105-
// - https://bugs.swift.org/browse/SR-2290
106-
// - https://github.com/norio-nomura/Nimble/pull/5#issuecomment-237835873
107-
if let number = actualValue as? NSNumber {
108-
return PredicateStatus(bool: number.boolValue == true)
109-
}
110-
111103
return PredicateStatus(bool: actualValue == (true as T))
112104
}
113105
return PredicateStatus(bool: actualValue != nil)
@@ -120,14 +112,6 @@ public func beFalsy<T: ExpressibleByBooleanLiteral & Equatable>() -> Predicate<T
120112
return Predicate.simpleNilable("be falsy") { actualExpression in
121113
let actualValue = try actualExpression.evaluate()
122114
if let actualValue = actualValue {
123-
// FIXME: This is a workaround to SR-2290.
124-
// See:
125-
// - https://bugs.swift.org/browse/SR-2290
126-
// - https://github.com/norio-nomura/Nimble/pull/5#issuecomment-237835873
127-
if let number = actualValue as? NSNumber {
128-
return PredicateStatus(bool: number.boolValue == false)
129-
}
130-
131115
return PredicateStatus(bool: actualValue == (false as T))
132116
}
133117
return PredicateStatus(bool: actualValue == nil)

0 commit comments

Comments
 (0)
Please sign in to comment.