Fixed most of commands creating a git repo instead of throwing an error

Author: JohanMabille

src/subcommand/add_subcommand.cpp

@@ -23,8 +23,7 @@ add_subcommand::add_subcommand(const libgit2_object&, CLI::App& app)
 void add_subcommand::run()
 {
     auto directory = get_current_git_path();
-    auto bare = false;
-    auto repo = repository_wrapper::init(directory, bare);
+    auto repo = repository_wrapper::open(directory);
 
     index_wrapper index = repo.make_index();
 

src/subcommand/commit_subcommand.cpp

@@ -19,8 +19,7 @@ commit_subcommand::commit_subcommand(const libgit2_object&, CLI::App& app)
 void commit_subcommand::run()
 {
     auto directory = get_current_git_path();
-    auto bare = false;
-    auto repo = repository_wrapper::init(directory, bare);
+    auto repo = repository_wrapper::open(directory);
     auto author_committer_signatures = signature_wrapper::get_default_signature_from_env(repo);
 
     if (m_commit_message.empty())

src/subcommand/log_subcommand.cpp

@@ -80,8 +80,7 @@ void print_commit(const commit_wrapper& commit, std::string m_format_flag)
 void log_subcommand::run()
 {
     auto directory = get_current_git_path();
-    auto bare = false;
-    auto repo = repository_wrapper::init(directory, bare);
+    auto repo = repository_wrapper::open(directory);
     // auto branch_name = repo.head().short_name();
 
     git_revwalk* walker;

src/subcommand/reset_subcommand.cpp

@@ -27,8 +27,7 @@ reset_subcommand::reset_subcommand(const libgit2_object&, CLI::App& app)
 void reset_subcommand::run()
 {
     auto directory = get_current_git_path();
-    auto bare = false;
-    auto repo = repository_wrapper::init(directory, bare);
+    auto repo = repository_wrapper::open(directory);
 
     auto target = repo.revparse_single(m_commit);
     if (!target)

src/subcommand/status_subcommand.cpp

@@ -183,8 +183,7 @@ void print_not_tracked(const std::vector<print_entry>& entries_to_print, const s
 void status_subcommand::run()
 {
     auto directory = get_current_git_path();
-    auto bare = false;
-    auto repo = repository_wrapper::init(directory, bare);
+    auto repo = repository_wrapper::open(directory);
     auto sl = status_list_wrapper::status_list(repo);
     auto branch_name = repo.head().short_name();
 

test/data/status_data/embedded_git/objects/48/e0bfd8a7f3ce1af86b7f7b855b25af8386ea54

@@ -32,3 +32,11 @@ def test_add(xtl_clone, git2cpp_path, tmp_path, all_flag):
         assert "Untracked files" not in p_status.stdout
     else:
         assert "Untracked files" in p_status.stdout
+
+def test_add_nogit(git2cpp_path, tmp_path):
+    p = tmp_path / "mook_file.txt"
+    p.write_text('')
+
+    cmd_add = [git2cpp_path, 'add', 'mook_file.txt']
+    p_add = subprocess.run(cmd_add, cwd=tmp_path, text=True)
+    assert p_add.returncode != 0