Skip to content

FIX: Deprecation and Future Warnings #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
May 19, 2025
Merged

FIX: Deprecation and Future Warnings #444

merged 26 commits into from
May 19, 2025

Conversation

mmcky
Copy link
Contributor

@mmcky mmcky commented Mar 12, 2025

This PR fixes #443 and #437

@mmcky mmcky added the in-work label Mar 12, 2025
Copy link

github-actions bot commented Apr 1, 2025

@github-actions github-actions bot temporarily deployed to pull request April 1, 2025 00:12 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 14, 2025 04:51 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 14, 2025 04:54 Inactive
@mmcky
Copy link
Contributor Author

mmcky commented May 14, 2025

@HumphreyYang this PR is changing some numpy notation. Would you mind double checking it for me?

The purpose is to remove the Deprecation warnings.

@mmcky mmcky requested a review from HumphreyYang May 14, 2025 06:12
Copy link
Collaborator

@HumphreyYang HumphreyYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks @mmcky,

The deprecation fix looks great to me!

@github-actions github-actions bot temporarily deployed to pull request May 15, 2025 03:54 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 19, 2025 00:54 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 19, 2025 00:56 Inactive
@mmcky mmcky removed the in-work label May 19, 2025
@mmcky
Copy link
Contributor Author

mmcky commented May 19, 2025

@HumphreyYang this is now updated to include all lectures documented in the title linked issues.

IF you have time, can you please have a quick flip through the diff for me. Thanks.

@mmcky mmcky requested a review from HumphreyYang May 19, 2025 01:55
@github-actions github-actions bot temporarily deployed to pull request May 19, 2025 03:13 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 19, 2025 03:14 Inactive
Copy link
Collaborator

@HumphreyYang HumphreyYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks @mmcky. This looks great! Just one note I took. Please feel free to discard!

Comment on lines 607 to 611
```{code-cell} ipython3
## to check that gpu is activated in environment

from jax.lib import xla_bridge
print(xla_bridge.get_backend().platform)
print(f"JAX backend: {jax.devices()[0].platform}")
```

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mmcky,

This note is at the end of the lecture. Should we move it with the note below to the top?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @HumphreyYang I will add that change and then merge.

Appreciate you taking a look.

@github-actions github-actions bot temporarily deployed to pull request May 19, 2025 04:53 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 19, 2025 04:55 Inactive
@mmcky mmcky merged commit b7349e4 into main May 19, 2025
7 checks passed
@mmcky mmcky deleted the fix-deprecation+future branch May 19, 2025 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecation and FutureWarnings
2 participants