-
-
Notifications
You must be signed in to change notification settings - Fork 48
FIX: Deprecation and Future Warnings #444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@HumphreyYang this PR is changing some The purpose is to remove the Deprecation warnings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks @mmcky,
The deprecation fix looks great to me!
…/lecture-python.myst into fix-deprecation+future
@HumphreyYang this is now updated to include all lectures documented in the title linked issues. IF you have time, can you please have a quick flip through the diff for me. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks @mmcky. This looks great! Just one note I took. Please feel free to discard!
lectures/back_prop.md
Outdated
```{code-cell} ipython3 | ||
## to check that gpu is activated in environment | ||
|
||
from jax.lib import xla_bridge | ||
print(xla_bridge.get_backend().platform) | ||
print(f"JAX backend: {jax.devices()[0].platform}") | ||
``` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mmcky,
This note is at the end of the lecture. Should we move it with the note below to the top?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @HumphreyYang I will add that change and then merge.
Appreciate you taking a look.
This PR fixes #443 and #437