Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review unit tests failing randomly #8492

Open
4 tasks done
Martin-Molinero opened this issue Jan 2, 2025 · 0 comments
Open
4 tasks done

Review unit tests failing randomly #8492

Martin-Molinero opened this issue Jan 2, 2025 · 0 comments

Comments

@Martin-Molinero
Copy link
Member

Expected Behavior

Unit tests pass always

Actual Behavior

Some unit tests fails now and then in GH CI

  Failed FineCoarseFundamentalDataGetsPipedCorrectly(2) [153 ms]
  Error Message:
     Assert.That(condition, Is.True)
  Expected: True
  But was:  False


  Failed ConstituentsUniverse [330 ms]
  Error Message:
     Did not yielded Symbols
Assert.That(condition, Is.True)
  Expected: True
  But was:  False


  Failed FutureLiveHoldingsFutureMapping [253 ms]
  Error Message:
     Assert.That(condition, Is.True)
  Expected: True
  But was:  False

Potential Solution

  • Review and understand each unit test and reason of failure
  • Potential solutions could be add some reset event to avoid indeterminism, increase/reduce some time step or sleep, etc

Reproducing the Problem

N/A

System Information

N/A

Checklist

  • I have completely filled out this template
  • I have confirmed that this issue exists on the current master branch
  • I have confirmed that this is not a duplicate issue by searching issues
  • I have provided detailed steps to reproduce the issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant