cache canSeeCurationStatus perm check, render only for draft

Author: qqmyers

src/main/java/edu/harvard/iq/dataverse/search/SearchIncludeFragment.java

@@ -1547,13 +1547,18 @@ public boolean isValid(SolrSearchResult result) {
         });
     }
 
+    private Map<Long, Boolean> seesStatus = new HashMap<>();
+    
     public boolean canSeeCurationStatus(Long datasetId) {
-        boolean creatorsCanSeeStatus = JvmSettings.UI_SHOW_CURATION_STATUS_TO_ALL.lookupOptional(Boolean.class).orElse(false);
-        if (creatorsCanSeeStatus) {
-            return permissionsWrapper.canViewUnpublishedDataset(getDataverseRequest(),(Dataset) dvObjectService.findDvObject(datasetId));
-        } else {
-            return canPublishDataset(datasetId);
+        if (!seesStatus.containsKey(datasetId)) {
+            boolean creatorsCanSeeStatus = JvmSettings.UI_SHOW_CURATION_STATUS_TO_ALL.lookupOptional(Boolean.class).orElse(false);
+            if (creatorsCanSeeStatus) {
+                seesStatus.put(datasetId, permissionsWrapper.canViewUnpublishedDataset(getDataverseRequest(), (Dataset) dvObjectService.findDvObject(datasetId)));
+            } else {
+                seesStatus.put(datasetId, canPublishDataset(datasetId));
+            }
         }
+        return seesStatus.get(datasetId);
     }
 
     public enum SortOrder {

src/main/webapp/search-include-fragment.xhtml

@@ -583,7 +583,7 @@
                             <h:outputText value="#{bundle['dataset.versionUI.deaccessioned']}" styleClass="label label-danger" rendered="#{result.deaccessionedState}"/>
                             <h:outputText value="#{bundle['embargoed']}" styleClass="label label-primary" rendered="#{SearchIncludeFragment.isActivelyEmbargoed(result)}"/>
                             <h:outputText value="#{bundle['retentionExpired']}" styleClass="label label-warning" rendered="#{SearchIncludeFragment.isRetentionExpired(result)}"/>
-                            <h:outputText value="#{DatasetUtil:getLocaleCurationStatusLabelFromString(result.curationStatus)}" styleClass="label curation-status" rendered="#{SearchIncludeFragment.canSeeCurationStatus(result.entityId)}"/>
+                            <h:outputText value="#{DatasetUtil:getLocaleCurationStatusLabelFromString(result.curationStatus)}" styleClass="label curation-status" rendered="#{result.draftState and SearchIncludeFragment.canSeeCurationStatus(result.entityId)}"/>
                             <h:outputText value="#{result.userRole}" styleClass="label label-primary" rendered="#{!empty result.userRole}"/>
                             <h:outputText value="#{bundle['incomplete']}" styleClass="label label-danger" rendered="#{!result.harvested and !SearchIncludeFragment.isValid(result)}"/>
                         </div>