fix: simple javascript errors (#220)

* fix: Don't crash when the directory is already exists.
* fix: Few JS lints & undefined error.
* fix: Fix filetree alignment and hide badges on folders.

Co-authored-by: Or Ronai <[email protected]>

Author: yammesicka

.eslintrc.js

@@ -5,6 +5,7 @@ module.exports = {
   },
   globals: {
     bootstrap: true,
+    Dropzone: true,
   },
   extends: [
     'airbnb-base',

lms/static/my.css

@@ -271,6 +271,15 @@ button#share-action:hover {
   overflow-x: unset;
 }
 
+.file-comments-count {
+  width: 1em;
+  height: 1.5em;
+  display: flex;
+  align-self: center;
+  justify-self: center;
+  margin: 0 0.25em;
+}
+
 #files {
   list-style-type: none;
   text-align: left;

lms/static/my.js

@@ -81,6 +81,10 @@ function trackDisableShareButton(solutionId, button) {
 function updateNotificationsBadge() {
   const dropdown = document.getElementById('navbarNavDropdown');
   const container = document.getElementById('notifications-list');
+  if (dropdown === null || container === null) {
+    return;
+  }
+
   const unread = container.querySelectorAll('.dropdown-item[data-read="false"]');
   const counter = dropdown.querySelector('#notification-count');
   const bgColor = (unread.length > 0) ? badColor : naturalColor;
@@ -95,6 +99,10 @@ function sendReadAllNotificationsRequest() {
 }
 
 function trackReadAllNotificationsButton(button) {
+  if (button === null) {
+    return;
+  }
+
   button.addEventListener('click', () => {
     sendReadAllNotificationsRequest();
     const notifications = document.querySelectorAll('.dropdown-item[data-read="false"]');
@@ -105,20 +113,9 @@ function trackReadAllNotificationsButton(button) {
   });
 }
 
-function getPostUploadMessage() {
-  const myDropzone = Dropzone.forElement('#demo-upload');
-  const feedbacks = document.getElementById('upload-feedbacks');
-  const matchesSpan = document.getElementById('upload-matches');
-  const missesSpan = document.getElementById('upload-misses');
-  myDropzone.on('success', function() {
-    const uploadStatus = Array.from(arguments).slice(1)[0];
-    postUploadMessageUpdate(feedbacks, uploadStatus, matchesSpan, missesSpan);
-  });
-}
-
 function postUploadMessageUpdate(feedbacks, uploadStatus, matchesSpan, missesSpan) {
-  const matches = uploadStatus['exercise_matches'];
-  const misses = uploadStatus['exercise_misses'];
+  const matches = uploadStatus.exercise_matches;
+  const misses = uploadStatus.exercise_misses;
   if (!feedbacks.classList.contains('feedback-hidden')) {
     feedbacks.classList.add('feedback-hidden');
   }
@@ -131,19 +128,32 @@ function postUploadMessageUpdate(feedbacks, uploadStatus, matchesSpan, missesSpa
     missesSpan.classList.remove('feedback-hidden');
   }
   feedbacks.classList.add('feedback-transition');
-  feedbacks.clientWidth;  // Forces layout to ensure the transition
+  feedbacks.clientWidth; // Forces layout to ensure the transition
   feedbacks.classList.remove('feedback-hidden');
-  feedbacks.addEventListener('transitionend', function() {
+  feedbacks.addEventListener('transitionend', () => {
     feedbacks.classList.remove('feedback-transition');
   });
 }
 
+function getPostUploadMessage() {
+  const myDropzone = Dropzone.forElement('#demo-upload');
+  const feedbacks = document.getElementById('upload-feedbacks');
+  const matchesSpan = document.getElementById('upload-matches');
+  const missesSpan = document.getElementById('upload-misses');
+  myDropzone.on('success', (...args) => {
+    const uploadStatus = Array.from(args).slice(1)[0];
+    if (uploadStatus !== null) {
+      postUploadMessageUpdate(feedbacks, uploadStatus, matchesSpan, missesSpan);
+    }
+  });
+}
+
 window.escapeUnicode = escapeUnicode;
 
 window.addEventListener('load', () => {
   updateNotificationsBadge();
   trackReadAllNotificationsButton(document.getElementById('read-notifications'));
-  const codeElement = document.getElementById('code-view')
+  const codeElement = document.getElementById('code-view');
   if (codeElement !== null) {
     const codeElementData = codeElement.dataset;
     const solutionId = codeElementData.id;