Skip to content

Conversation

Lash-L
Copy link
Collaborator

@Lash-L Lash-L commented Sep 22, 2025

Fixing this logic so it can be used correctly in core

allenporter
allenporter previously approved these changes Sep 27, 2025
Copy link
Contributor

@allenporter allenporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A test that reproduces the issue would be ideal as well.

Copy link
Contributor

@allenporter allenporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, test looks great.

@Lash-L Lash-L requested a review from allenporter September 29, 2025 00:39
@allenporter
Copy link
Contributor

Commit lint failed on the commit from the github suggestion.

@Lash-L Lash-L merged commit d7d0a3b into main Sep 29, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants