Skip to content

Commit d750234

Browse files
authored
fix: add additional log messages to track down concurrency errors (#266)
1 parent e14802c commit d750234

File tree

3 files changed

+8
-0
lines changed

3 files changed

+8
-0
lines changed

roborock/version_1_apis/roborock_client_v1.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -391,6 +391,8 @@ def on_message_received(self, messages: list[RoborockMessage]) -> None:
391391
if isinstance(result, list) and len(result) == 1:
392392
result = result[0]
393393
queue.resolve((result, None))
394+
else:
395+
self._logger.debug("Received response for unknown request id %s", request_id)
394396
else:
395397
try:
396398
data_protocol = RoborockDataProtocol(int(data_point_number))
@@ -443,10 +445,14 @@ def on_message_received(self, messages: list[RoborockMessage]) -> None:
443445
if isinstance(decompressed, list):
444446
decompressed = decompressed[0]
445447
queue.resolve((decompressed, None))
448+
else:
449+
self._logger.debug("Received response for unknown request id %s", request_id)
446450
else:
447451
queue = self._waiting_queue.get(data.seq)
448452
if queue:
449453
queue.resolve((data.payload, None))
454+
else:
455+
self._logger.debug("Received response for unknown request id %s", data.seq)
450456
except Exception as ex:
451457
self._logger.exception(ex)
452458

roborock/version_1_apis/roborock_local_client_v1.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ def build_roborock_message(
1818
) -> RoborockMessage:
1919
secured = True if method in COMMANDS_SECURED else False
2020
request_id, timestamp, payload = self._get_payload(method, params, secured)
21+
self._logger.debug("Building message id %s for method %s", request_id, method)
2122
request_protocol = RoborockMessageProtocol.GENERAL_REQUEST
2223
message_retry: MessageRetry | None = None
2324
if method == RoborockCommand.RETRY_REQUEST and isinstance(params, dict):

roborock/version_1_apis/roborock_mqtt_client_v1.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,7 @@ async def _send_command(
7474
# When we have more custom commands do something more complicated here
7575
return await self._get_calibration_points()
7676
request_id, timestamp, payload = self._get_payload(method, params, True)
77+
self._logger.debug("Building message id %s for method %s", request_id, method)
7778
request_protocol = RoborockMessageProtocol.RPC_REQUEST
7879
roborock_message = RoborockMessage(timestamp=timestamp, protocol=request_protocol, payload=payload)
7980
return await self.send_message(roborock_message)

0 commit comments

Comments
 (0)