fix: close the session if we created it (#356)

Author: Lash-L

roborock/web_api.py

@@ -36,8 +36,6 @@ def __init__(self, username: str, base_url=None, session: aiohttp.ClientSession
         self._default_url = "https://euiot.roborock.com"
         self.base_url = base_url
         self._device_identifier = secrets.token_urlsafe(16)
-        if session is None:
-            session = aiohttp.ClientSession()
         self.session = session
 
     async def _get_base_url(self) -> str:
@@ -470,18 +468,20 @@ async def download_category_code(self, user_data: UserData):
 
 
 class PreparedRequest:
-    def __init__(self, base_url: str, session: aiohttp.ClientSession, base_headers: dict | None = None) -> None:
+    def __init__(
+        self, base_url: str, session: aiohttp.ClientSession | None = None, base_headers: dict | None = None
+    ) -> None:
         self.base_url = base_url
         self.base_headers = base_headers or {}
         self.session = session
 
     async def request(self, method: str, url: str, params=None, data=None, headers=None, json=None) -> dict:
         _url = "/".join(s.strip("/") for s in [self.base_url, url])
         _headers = {**self.base_headers, **(headers or {})}
+        close_session = self.session is None
+        session = self.session if self.session is not None else aiohttp.ClientSession()
         try:
-            async with self.session.request(
-                method, _url, params=params, data=data, headers=_headers, json=json
-            ) as resp:
+            async with session.request(method, _url, params=params, data=data, headers=_headers, json=json) as resp:
                 return await resp.json()
         except ContentTypeError as err:
             """If we get an error, lets log everything for debugging."""
@@ -494,3 +494,6 @@ async def request(self, method: str, url: str, params=None, data=None, headers=N
             _LOGGER.info("Resp raw: %s", resp_raw)
             # Still raise the err so that it's clear it failed.
             raise err
+        finally:
+            if close_session:
+                await session.close()

tests/test_web_api.py

@@ -1,13 +1,17 @@
+import aiohttp
+
 from roborock import HomeData, HomeDataScene, UserData
 from roborock.web_api import RoborockApiClient
 from tests.mock_data import HOME_DATA_RAW, USER_DATA
 
 
 async def test_pass_login_flow() -> None:
     """Test that we can login with a password and we get back the correct userdata object."""
-    api = RoborockApiClient(username="[email protected]")
+    my_session = aiohttp.ClientSession()
+    api = RoborockApiClient(username="[email protected]", session=my_session)
     ud = await api.pass_login("password")
     assert ud == UserData.from_dict(USER_DATA)
+    assert not my_session.closed
 
 
 async def test_code_login_flow() -> None: