From d26ce43c9c6c10a867254b09dce787fd8a6c8118 Mon Sep 17 00:00:00 2001 From: Claude Date: Mon, 24 Aug 2026 20:19:22 +0000 Subject: [PATCH] =?UTF-8?q?prompt:=20ship=20phase5-smoke-ordered-trap-scri?= =?UTF-8?q?pts=20(autocti=5Fworkspace#27)=20=E2=86=92=20complete?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit CTI epic Phase 5. autocti_workspace#28 merged; smoke green on 3.12 and 3.13. The prompt's premise did not hold: autocti_workspace has no smoke_tests.txt and never had one — no .github/, no config/build/, nothing deleted in history. So this created the repo's FIRST CI rather than re-enabling coverage, which is why the task was larger than its "add lines to a file" sizing. It also closes pre-existing drift: PyAutoHeart/config/repos.yaml already lists the repo under `workspaces`, whose required checks are "Smoke Tests" + "Navigator Check", with neither workflow present. All nine modeling/start_here.py-class scripts verified running bypassed against PyAutoFit 438f56fac (main HEAD), output/ cleared between every run. The fix is visible in the output: the two identical-prior traps resolve to 0.14 and 1.68, distinct and correctly ordered, instead of tying at the prior medians. Promoted a curated three (132s cold, CI measured 129s/123s) rather than all nine (~522s), against a measured 20s baseline for the existing CTI smoke suite. Full per-script timings recorded in the workspace's AGENTS.md. Record also carries two follow-ups: Navigator Check is still absent for this repo, and Heart's local smoke runner table has no autocti entry. The autocti_workspace_test "single-trap" convention question is left open for a human, as intended. Co-Authored-By: Claude Opus 5 Claude-Session: https://claude.ai/code/session_018nDAxBEavkzb6Zkz1cYHef --- active.md | 20 --- ...se5_smoke_reenable_ordered_trap_scripts.md | 25 ---- .../08/phase5-smoke-ordered-trap-scripts.md | 131 ++++++++++++++++++ complete/index.md | 3 +- dashboard.html | 17 ++- dashboard.md | 20 +-- 6 files changed, 147 insertions(+), 69 deletions(-) delete mode 100644 active/phase5_smoke_reenable_ordered_trap_scripts.md create mode 100644 complete/2026/08/phase5-smoke-ordered-trap-scripts.md diff --git a/active.md b/active.md index fe8004a7..fb25a165 100644 --- a/active.md +++ b/active.md @@ -1,25 +1,5 @@ # Active Tasks -## phase5-smoke-ordered-trap-scripts -- issue: https://github.com/PyAutoLabs/autocti_workspace/issues/27 -- issued: 2026-08-24 -- prompt: active/phase5_smoke_reenable_ordered_trap_scripts.md -- status: workspace-dev -- worktree: ~/Code/PyAutoLabs-wt/phase5-smoke-ordered-trap-scripts -- repos: - - autocti_workspace: feature/phase5-smoke-ordered-trap-scripts -- summary: | - CTI epic Phase 5. PR autocti_workspace#28 open, CI running. The prompt's - premise was wrong: autocti_workspace has no smoke_tests.txt and never had one - (no .github/, no config/build/, nothing deleted in history), so this creates - the repo's first CI rather than re-enabling anything — which also closes - pre-existing drift, since PyAutoHeart/config/repos.yaml already lists this - repo under `workspaces` with required checks "Smoke Tests" + "Navigator - Check". All nine modeling/start_here.py-class scripts verified running - bypassed against PyAutoFit 438f56fac; a curated three promoted (132s cold) - rather than all nine (~522s), per the repos' no-mass-promote convention. - Navigator Check deliberately left out of scope. - ## transformed-message-factor-gradient-unpack - issue: https://github.com/PyAutoLabs/PyAutoFit/issues/1501 (issued 2026-08-19) - issued: 2026-08-19 diff --git a/active/phase5_smoke_reenable_ordered_trap_scripts.md b/active/phase5_smoke_reenable_ordered_trap_scripts.md deleted file mode 100644 index df200333..00000000 --- a/active/phase5_smoke_reenable_ordered_trap_scripts.md +++ /dev/null @@ -1,25 +0,0 @@ -# Re-enable autocti_workspace smoke coverage of the ordered-trap modeling scripts - -Type: test -Target: autocti_workspace -Repos: -- @autocti_workspace -Difficulty: medium -Autonomy: supervised -Priority: normal -Status: formalised -Filed: 2026-08-24 -Issued: 2026-08-24 -Epic: CTI resurrection — Phase 5 - -Re-homed from `draft/test/autofit/` by the filing session. Intake set -`Target: PyAutoFit` and listed PyAutoFit as an affected repo — wrong on both: -the PyAutoFit fix has already merged (438f56fac), so this task changes no -library source and only needs a PyAutoFit main that contains it. Difficulty -lowered from `large`: the work is verify-scripts-run, add lines to -`smoke_tests.txt`, and time them against the gate cap — sized by script count, -which is not yet known, hence `medium` rather than `small`. - -Re-enable @autocti_workspace smoke coverage of the modeling/start_here.py-class scripts, unblocked by PyAutoFit#1520 (merged 438f56fac). Those scripts were un-smokeable at PYAUTO_TEST_MODE=2 because ordered trap models tie at the prior medians and the bypass hard-failed; the bypass now selects a deterministic assertion-valid point, at TEST_MODE 2 and 3. This is CTI resurrection epic Phase 5. Work: confirm the scripts now run bypassed against a PyAutoFit main that includes 438f56fac, add them back to the workspace smoke_tests.txt, and check timings against the smoke gate cap before adding them. - - diff --git a/complete/2026/08/phase5-smoke-ordered-trap-scripts.md b/complete/2026/08/phase5-smoke-ordered-trap-scripts.md new file mode 100644 index 00000000..0576fc23 --- /dev/null +++ b/complete/2026/08/phase5-smoke-ordered-trap-scripts.md @@ -0,0 +1,131 @@ +- completed: 2026-08-24 +- issue: https://github.com/PyAutoLabs/autocti_workspace/issues/27 +- prs: + - https://github.com/PyAutoLabs/autocti_workspace/pull/28 (merged) +- summary: | + CTI resurrection epic **Phase 5**. Smoke coverage for the ordered-trap + `modeling/start_here.py`-class scripts, unblocked by PyAutoFit#1520 + (`438f56fac`). All nine verified running bypassed; a curated three promoted. + This is autocti_workspace's FIRST CI. + +## The prompt's premise did not hold + +The prompt said to "add them back to the workspace `smoke_tests.txt`". **There is +no `smoke_tests.txt`, and never was.** autocti_workspace has no `.github/` +directory and no `config/build/`; `git ls-files` finds neither, and +`git log --diff-filter=D` shows nothing was ever deleted. So the coverage had to +be *created*, not re-enabled — which is why the task was larger than its +"add lines to a file" sizing suggested. + +That also surfaced pre-existing drift worth knowing about: +`PyAutoHeart/config/repos.yaml` lists autocti_workspace under `workspaces`, +whose required checks are `["Smoke Tests", "Navigator Check"]`. Neither workflow +existed, so that gate had been vacuous. This PR closes the smoke half. +(Heart's *local* smoke runner table — the `smoke:` block in the same file — has +no autocti entry either, and its `import_names` map has no PyAutoCTI. Untouched +here; a genuine follow-up.) + +## Verification — all nine run bypassed + +Stack built from source `main` with PyAutoFit at `438f56fac` (which is `main` +HEAD, so "a PyAutoFit main containing that SHA" is satisfied by definition), +autonerves/autoarray 2026.8.17.1, autocti 2024.11.13.2, arcticpy 2.6. + +`output/` cleared between EVERY run. This matters: a bypassed fit calls +`paths.completed()`, so re-running with the same `unique_tag` replays the old +result via `result_via_completed_fit` and looks exactly like "the fix didn't +work". + +| script | time | promoted | +|---|---|---| +| `dataset_1d/modeling/start_here.py` | 13 s | yes | +| `dataset_1d/modeling/customize/priors.py` | 12 s | no | +| `dataset_1d/modeling/features/species_x3.py` | 18 s | yes | +| `dataset_1d/modeling/features/visualize_full.py` | 20 s | no | +| `imaging_ci/modeling/start_here.py` | 96 s | yes | +| `imaging_ci/modeling/features/cosmic_rays.py` | 120 s | no | +| `imaging_ci/modeling/features/non_uniform.py` | 53 s | no | +| `imaging_ci/modeling/features/serial_cti.py` | 94 s | no | +| `imaging_ci/modeling/features/visualize_full.py` | 96 s | no | + +All nine **pass**. The fix is directly visible in the output: +`dataset_1d/modeling/start_here.py` builds two `TrapInstantCapture` models with +identical priors under `trap_0.release_timescale < trap_1.release_timescale`, +and resolves them to `0.14` and `1.68` — distinct and correctly ordered — rather +than tying at the prior medians and hard-failing the bypass. + +## Why three, not nine + +Every CTI repo's AGENTS.md says to keep the smoke list a small curated subset +and not to mass-promote. Measured the existing CTI smoke suite +(autocti_workspace_test) for a like-for-like baseline: **20 s** total +(8 + 5 + 7). All nine here cost **~522 s** — a ~26x jump on the CTI smoke bill. + +Promoted three, covering both dataset geometries and the multi-species +ordered-trap case — the surface the bypass fix actually unblocked. **132 s +measured cold**, with `dataset/` wiped to its committed state so every dataset +is simulated first (datasets are gitignored and auto-simulated by the scripts' +`should_simulate` guards, so a fresh CI checkout always pays that). + +CI confirmed the estimate: the runner step took **129 s** on Python 3.12 and +~123 s on 3.13. Both legs green. + +## What was added + +- `.github/workflows/smoke_tests.yml` — thin caller for Heart's reusable smoke + workflow, chain `PyAutoNerves PyAutoFit PyAutoArray PyAutoCTI`, `arcticpy: true`. +- `.github/scripts/smoke_install.sh` — install epilogue carrying **no** arcticpy + recipe; the same-day arcticpy-install-standardisation task made Heart's + `install-arcticpy` action its single owner, and Heart runs it before this + epilogue. This repo never had a copy to delete. +- `.github/scripts/run_smoke.py` — thin shim over PyAutoHands' `run_python.py`, + mirroring autocti_workspace_test's. Holds no logic, so it needs none of the + sweeps the old 198-line copies did. +- `config/build/profile_smoke.yaml` — `PYAUTO_TEST_MODE=2` and cache dirs. + Passed Heart's strict env-profile validator first time. +- `smoke_tests.txt` — the curated three. +- `AGENTS.md` — a "Smoke tests (CI)" section carrying the full nine-script + timing table, so the next person promoting a script starts from numbers. + +## Left undone, deliberately + +**Navigator Check.** Heart lists it as a required check for this repo alongside +Smoke Tests and it is still absent. Out of scope for an ordered-trap smoke task; +adding a second unrelated workflow would have widened the PR. Worth a follow-up +prompt. + +## Still open for a human + +autocti_workspace_test's `## Conventions` says integration scripts are +"single-trap" with no stated reason. The reason was almost certainly the bypass +crash, which is now fixed — so either drop it and exercise multi-trap ordered +models (better coverage, since ordered traps are the realistic CTI case), or +write the real reason in. Deliberately not decided here. + +## Original prompt + +# Re-enable autocti_workspace smoke coverage of the ordered-trap modeling scripts + +Type: test +Target: autocti_workspace +Repos: +- @autocti_workspace +Difficulty: medium +Autonomy: supervised +Priority: normal +Status: formalised +Filed: 2026-08-24 +Issued: 2026-08-24 +Epic: CTI resurrection — Phase 5 + +Re-homed from `draft/test/autofit/` by the filing session. Intake set +`Target: PyAutoFit` and listed PyAutoFit as an affected repo — wrong on both: +the PyAutoFit fix has already merged (438f56fac), so this task changes no +library source and only needs a PyAutoFit main that contains it. Difficulty +lowered from `large`: the work is verify-scripts-run, add lines to +`smoke_tests.txt`, and time them against the gate cap — sized by script count, +which is not yet known, hence `medium` rather than `small`. + +Re-enable @autocti_workspace smoke coverage of the modeling/start_here.py-class scripts, unblocked by PyAutoFit#1520 (merged 438f56fac). Those scripts were un-smokeable at PYAUTO_TEST_MODE=2 because ordered trap models tie at the prior medians and the bypass hard-failed; the bypass now selects a deterministic assertion-valid point, at TEST_MODE 2 and 3. This is CTI resurrection epic Phase 5. Work: confirm the scripts now run bypassed against a PyAutoFit main that includes 438f56fac, add them back to the workspace smoke_tests.txt, and check timings against the smoke gate cap before adding them. + + diff --git a/complete/index.md b/complete/index.md index 7a492ee3..0e4a1b43 100644 --- a/complete/index.md +++ b/complete/index.md @@ -6,7 +6,7 @@ Token-light navigation over the finished-work records (schema: only then grep a dated bucket. Curators: edit the band between the CURATED markers; everything below GENERATED is rebuilt. -1118 records across 7 buckets. +1119 records across 7 buckets. ## Highlights @@ -149,6 +149,7 @@ _(curate hard-won records here — survives regeneration.)_ - [paper-management-pipeline](2026/08/paper-management-pipeline.md) — auto-closed on merge - [per-parameter-step-scaling](2026/08/per-parameter-step-scaling.md) - [persist-smoke-environments](2026/08/persist-smoke-environments.md) — Made smoke dependency environments durable and isolated per library and Python version, with version-handshake… +- [phase5-smoke-ordered-trap-scripts](2026/08/phase5-smoke-ordered-trap-scripts.md) - [pix-prodigy-gpu-compat](2026/08/pix-prodigy-gpu-compat.md) - [pixelization-eager-jit-divergence](2026/08/pixelization-eager-jit-divergence.md) - [plot-array-stale-kwargs](2026/08/plot-array-stale-kwargs.md) diff --git a/dashboard.html b/dashboard.html index 3bd446ff..3c7583c1 100644 --- a/dashboard.html +++ b/dashboard.html @@ -142,7 +142,7 @@

PyAutoMindDashboard

Intent. Priority. Flow.

Every task the Mind is holding. Tap a task's 📋 and its /start_dev command is on your clipboard — paste it into a Claude Code chat to route Claude straight to that task. Recent is the same work by date — what has been happening rather than what to do next.

- +

Last updated 2026-08-24. This page is generated from active/, draft/ and the registry files, so it is only as current as they are. dashboard_refresh.yml re-renders it on every push to main — that heals a stale page, but not a stale prompt: a task that shipped without its prompt advancing to complete/ keeps rendering here as pickable backlog. Reconciling those is the refresh below.

@PyAutoFit TransformedMessage.factor_gradient crashes on first call — issue #1501 — issued 2026-08-19 — HOLD — do not start dev. Fix-or-delete hangs off the PyAutoFit#1498 logpdf-contract

-

Re-enable autocti_workspace smoke coverage of the ordered-trap modeling scripts — issue #27 — issued 2026-08-24 — workspace-dev

Parked markdown version

3 task(s) @@ -374,12 +373,6 @@

Backlog -2026-08-24 -issued -Re-enable autocti_workspace smoke coverage of the ordered-trap… - - - 2026-08-23 filed pynufft removal: unswept downstream residue (1 hard break + stale… @@ -415,7 +408,7 @@

Backlog The reconstruction noise map describes a different estimator than the… - + 2026-08-22 filed Point-source JSON datasets record no resolution regime @@ -655,6 +648,12 @@

Backlog Nightly release has been blocked 8 nights running — triage the streak + +2026-08-04 +filed +HowToLens ch4 tutorial 3: mask overlay is never actually drawn + +

Epics markdown version

diff --git a/dashboard.md b/dashboard.md index 2845faca..c3cca801 100644 --- a/dashboard.md +++ b/dashboard.md @@ -42,7 +42,7 @@ anything you could not verify. | Where | Count | |-------|------:| -| [In flight](#in-flight) (`active/`) | 2 | +| [In flight](#in-flight) (`active/`) | 1 | | [Parked](#parked) (`parked.md`) | 3 | | [Planned](#planned) (`planned.md`) | 5 | | [Backlog](#backlog) (`draft/`) | 139 | @@ -185,14 +185,6 @@ Issued — each has an open GitHub issue and usually a branch. The full record f
-
📋 Re-enable autocti_workspace smoke coverage of the ordered-trap modeling scripts — issue #27 — issued 2026-08-24 — workspace-dev - -``` -/start_dev active/phase5_smoke_reenable_ordered_trap_scripts.md -``` - -
- ## Parked Started or scoped, not currently in flight — resume by moving the row back to `active.md`. Full detail in [`parked.md`](parked.md). @@ -1245,19 +1237,18 @@ The 50 newest things to happen to the work in hand, newest first — issued, par | 2026-08-24 | filed | interferometer/jax_grad/gradient.py: eager and jitted likelihoods… | | 2026-08-24 | filed | Un-park multi_galaxy/features/scaling_relation/slam once a capped run… | | 2026-08-24 | filed | The weekly smoke run's timings land in results-* under no… | -| 2026-08-24 | issued | Re-enable autocti_workspace smoke coverage of the ordered-trap… | | 2026-08-23 | filed | pynufft removal: unswept downstream residue (1 hard break + stale… | | 2026-08-23 | filed | Phase 3: stop installing pynufft in Hands/Heart CI and PyAutoCTI… | | 2026-08-23 | filed | Brain board follow-ups: what real mornings surface | | 2026-08-22 | filed | smoke_install.sh's stale jax<0.7 pin — CI is on the right jax… | | 2026-08-22 | filed | Untrack the generated FITS test artifacts in autoarray | | 2026-08-22 | filed | The reconstruction noise map describes a different estimator than the… | +| 2026-08-22 | filed | Point-source JSON datasets record no resolution regime |
… 10 more (40 left) | Date | Event | Task | |------|-------|------| -| 2026-08-22 | filed | Point-source JSON datasets record no resolution regime | | 2026-08-22 | filed | Is Intel macOS a supported platform, and what is the numpy-only… | | 2026-08-22 | filed | Defer the eager scipy.sparse import in derivative_util (~0.10 s of… | | 2026-08-22 | filed | Bug: fix the tracer.fits existence guard in autolens_workspace… | @@ -1267,12 +1258,12 @@ The 50 newest things to happen to the work in hand, newest first — issued, par | 2026-08-19 | filed | status.sh --repos sources a file that no longer exists | | 2026-08-19 | filed | jax 0.11 breaks beta/gamma message log_partition under jit… | | 2026-08-19 | filed | autolens_workspace_test jax_likelihood pins: 4 scripts fail smoke on… | +| 2026-08-19 | filed | autofit_profiling: bootstrap the repo + general PyAutoFit profiling… |
… 10 more (30 left) | Date | Event | Task | |------|-------|------| -| 2026-08-19 | filed | autofit_profiling: bootstrap the repo + general PyAutoFit profiling… | | 2026-08-19 | filed | autoreduce 0.9 on PyPI never got the Python 3.12 floor | | 2026-08-19 | issued | @PyAutoFit TransformedMessage.factor_gradient crashes on first… | | 2026-08-19 | filed | Release board: local run_logs enrichment | @@ -1282,12 +1273,12 @@ The 50 newest things to happen to the work in hand, newest first — issued, par | 2026-08-19 | filed | Deduplicate repos_sync.py's check/write pairs | | 2026-08-19 | filed | Bug in autocti_workspace: the dataset_1d results/database example… | | 2026-08-18 | parked | single-source-density-design | +| 2026-08-18 | parked | prior-message-collapse-design |
… 10 more (20 left) | Date | Event | Task | |------|-------|------| -| 2026-08-18 | parked | prior-message-collapse-design | | 2026-08-18 | filed | @PyAutoFit TransformedMessage.logpdf/pdf omit the transform… | | 2026-08-17 | filed | Which other searches need prior-support handling — coverage audit… | | 2026-08-17 | filed | Teach repos_sync --write to stamp organ config surfaces | @@ -1297,12 +1288,12 @@ The 50 newest things to happen to the work in hand, newest first — issued, par | 2026-08-08 | parked | pyautoreduce-slacs1430-acs-comparison | | 2026-08-08 | filed | Regenerate autolens_workspace markdown/ so the MGE pages show… | | 2026-08-07 | filed | autofit.plot functions accept **kwargs and silently discard them | +| 2026-08-07 | filed | Regenerate setup_notebook-drifted notebooks in… |
… 10 more (10 left) | Date | Event | Task | |------|-------|------| -| 2026-08-07 | filed | Regenerate setup_notebook-drifted notebooks in… | | 2026-08-06 | filed | Triage: Convolver "No blurring_image provided" warning in canonical… | | 2026-08-06 | filed | Rewrite PyAutoCTI docs/api — 55 of 89 autosummary entries are dead | | 2026-08-06 | filed | Dependency-cap refresh 2026-08: safe bumps, astropy 8 decision, two… | @@ -1312,6 +1303,7 @@ The 50 newest things to happen to the work in hand, newest first — issued, par | 2026-08-04 | filed | autolens_workspace_developer: broad stale-API rot (56 symbols, no CI) | | 2026-08-04 | filed | aplt.Output stale-API drift in the remaining workspace repos | | 2026-08-04 | filed | Nightly release has been blocked 8 nights running — triage the streak | +| 2026-08-04 | filed | HowToLens ch4 tutorial 3: mask overlay is never actually drawn |