Skip to content

Commit b3f9709

Browse files
authored
Merge pull request #387 from Jammy2211/feature/jax_in_image_dict
Feature/jax in image dict
2 parents 2f8167c + fd83da4 commit b3f9709

4 files changed

Lines changed: 13 additions & 11 deletions

File tree

autolens/imaging/fit_imaging.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -172,6 +172,7 @@ def galaxy_image_dict(self) -> Dict[ag.Galaxy, np.ndarray]:
172172

173173
galaxy_image_2d_dict = self.tracer.galaxy_image_2d_dict_from(
174174
grid=self.grids.lp,
175+
xp=self._xp
175176
)
176177

177178
galaxy_linear_obj_image_dict = self.galaxy_linear_obj_data_dict_from(
@@ -199,6 +200,7 @@ def galaxy_model_image_dict(self) -> Dict[ag.Galaxy, np.ndarray]:
199200
grid=self.grids.lp,
200201
psf=self.dataset.psf,
201202
blurring_grid=self.grids.blurring,
203+
xp=self._xp
202204
)
203205

204206
galaxy_linear_obj_image_dict = self.galaxy_linear_obj_data_dict_from(

autolens/interferometer/fit_interferometer.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,9 @@ def galaxy_image_dict(self) -> Dict[ag.Galaxy, np.ndarray]:
173173
For modeling, this dictionary is used to set up the `adapt_images` that adapt certain pixelizations to the
174174
data being fitted.
175175
"""
176-
galaxy_image_dict = self.tracer.galaxy_image_2d_dict_from(grid=self.grids.lp)
176+
galaxy_image_dict = self.tracer.galaxy_image_2d_dict_from(
177+
grid=self.grids.lp, xp=self._xp
178+
)
177179

178180
galaxy_linear_obj_image_dict = self.galaxy_linear_obj_data_dict_from(
179181
use_operated=False
@@ -194,7 +196,7 @@ def galaxy_model_visibilities_dict(self) -> Dict[ag.Galaxy, np.ndarray]:
194196
are solved for first via the inversion.
195197
"""
196198
galaxy_model_visibilities_dict = self.tracer.galaxy_visibilities_dict_from(
197-
grid=self.grids.lp, transformer=self.dataset.transformer
199+
grid=self.grids.lp, transformer=self.dataset.transformer, xp=self._xp
198200
)
199201

200202
galaxy_linear_obj_visibilities_dict = self.galaxy_linear_obj_data_dict_from(

autolens/lens/tracer.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -579,7 +579,7 @@ def image_2d_via_input_plane_image_from(
579579
return aa.Array2D(values=image, mask=grid.mask, xp=xp)
580580

581581
def galaxy_image_2d_dict_from(
582-
self, grid: aa.type.Grid2DLike, operated_only: Optional[bool] = None
582+
self, grid: aa.type.Grid2DLike, xp=np, operated_only: Optional[bool] = None
583583
) -> Dict[ag.Galaxy, np.ndarray]:
584584
"""
585585
Returns a dictionary associating every `Galaxy` object in the `Tracer` with its corresponding 2D image, using
@@ -605,12 +605,14 @@ def galaxy_image_2d_dict_from(
605605

606606
galaxy_image_2d_dict = dict()
607607

608-
traced_grid_list = self.traced_grid_2d_list_from(grid=grid)
608+
traced_grid_list = self.traced_grid_2d_list_from(grid=grid, xp=xp)
609609

610610
for plane_index, galaxies in enumerate(self.planes):
611611
image_2d_list = [
612612
galaxy.image_2d_from(
613-
grid=traced_grid_list[plane_index], operated_only=operated_only
613+
grid=traced_grid_list[plane_index],
614+
operated_only=operated_only,
615+
xp=xp,
614616
)
615617
for galaxy in galaxies
616618
]

test_autolens/interferometer/test_fit_interferometer.py

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -180,12 +180,8 @@ def test___galaxy_image_dict(interferometer_7, interferometer_7_grid):
180180
tracer=tracer,
181181
)
182182

183-
assert fit.galaxy_image_dict[g0_linear][4] == pytest.approx(
184-
1.00018622848, 1.0e-2
185-
)
186-
assert fit.galaxy_image_dict[g1_linear][3] == pytest.approx(
187-
-0.017435532289, 1.0e-2
188-
)
183+
assert fit.galaxy_image_dict[g0_linear][4] == pytest.approx(1.00018622848, 1.0e-2)
184+
assert fit.galaxy_image_dict[g1_linear][3] == pytest.approx(-0.017435532289, 1.0e-2)
189185

190186
pixelization = al.Pixelization(
191187
mesh=al.mesh.RectangularUniform(shape=(3, 3)),

0 commit comments

Comments
 (0)