fix: genericise tenant repo names to clear the firewall gate

The tenant-firewall gate failed on all three legs: generic organ code must not
carry instance facts (satellite repo names) outside the declared config
surfaces. Six tokens across three files.

Refactored, not allowlisted, per the recorded doctrine ("derivable or arbitrary
-> refactor; genuine branded fact -> declare the surface"; a
comments/docstrings exemption was considered and rejected). None of these were
load-bearing: the illustrative workspace shapes are described structurally
(`dataset/<section>/<generated>/`) and the issue references live in the PR and
commit trail, which is not organ code. The allowlist does not grow.

Behaviour unchanged — comments, docstrings and test prose only. Suite still 370
passed, and reverting the originating workspace to its pre-fix state still
reproduces the failure with the exact file, line and resolved path.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01F11sMzmaVWfU6NCz1PKVVb

Author: 2 people

autohands/check_dataset_allowlist.py

@@ -17,7 +17,7 @@
 (Group B, PyAutoBuild#126) — the guard skips it with a notice rather than
 failing, until that repo opts in.
 
-Leg 2 (PyAutoArray#470) — the mirror-image failure. The check above asserts that
+Leg 2 — the mirror-image failure. The check above asserts that
 nothing *generated* got committed. This one asserts that nothing *committed* gets
 deleted: `should_simulate()` ends in `shutil.rmtree`, so a script that reaches an
 allowlisted dataset directory while `PYAUTO_SMALL_DATASETS=1` is still in force
@@ -247,11 +247,12 @@ def check_capped_deletion(prefixes, tracked) -> int:
 
     # The invariant is NOT "the path sits under an allowlist prefix" -- it is
     # "rmtree(path) would delete committed files". Those differ, and the prefix
-    # form over-reports: autocti_workspace commits five doc images directly in
-    # `dataset/overview/` while its overview scripts regenerate
-    # `dataset/overview/imaging_ci/uniform` and `dataset/overview/dataset_1d`,
-    # which hold nothing tracked. Deleting those destroys nothing. Prefix
-    # matching flagged all six as release-blocking failures.
+    # form over-reports. The shape that exposed it: a workspace commits a handful
+    # of documentation images directly in `dataset/<section>/`, while its scripts
+    # regenerate sibling subdirectories `dataset/<section>/<generated>/` that hold
+    # nothing tracked. Deleting those destroys nothing, but every one of them sits
+    # under the allowlist prefix, so prefix matching reported them all as
+    # release-blocking failures.
     def deletes_tracked(resolved: str) -> bool:
         return any(f == resolved or f.startswith(resolved + "/") for f in tracked)
 
@@ -293,7 +294,7 @@ def deletes_tracked(resolved: str) -> bool:
             "git-tracked files kept by design (they carry an `!dataset/...` allowlist "
             "line). Under PYAUTO_SMALL_DATASETS=1 those files are deleted and replaced "
             "with capped-simulator output. Add a releasing token to the script's "
-            "`__Env__` section (`ENV: full_datasets ...`) — see PyAutoArray#470.",
+            "`__Env__` section (`ENV: full_datasets ...`).",
             file=sys.stderr,
         )
         return 1

autohands/env_config.py

@@ -60,8 +60,8 @@
 # once. When auditing "which scripts still run capped / on NumPy / in test mode",
 # a script declaring `real_output` is already released on every one of them.
 # Treating the map as four single-var tokens under-counts the released set and
-# reports such a script as an offender; that mis-read cost real time during the
-# PyAutoArray#470 sweep. Derive membership from this map rather than hardcoding
+# reports such a script as an offender; that mis-read cost real time during a
+# cross-workspace audit. Derive membership from this map rather than hardcoding
 # a token list -- see `check_dataset_allowlist._releasing_tokens`.
 ENV_DECLARATION_TOKENS: Dict[str, tuple] = {
     "jax": ("PYAUTO_DISABLE_JAX",),

tests/test_dataset_allowlist_capped_deletion.py

@@ -1,4 +1,4 @@
-"""Regression tests for leg 2 of the dataset-allowlist guard (PyAutoArray#470).
+"""Regression tests for leg 2 of the dataset-allowlist guard.
 
 Leg 1 asserts nothing *generated* got committed. Leg 2 asserts nothing
 *committed* gets deleted: ``should_simulate`` ends in ``shutil.rmtree``, so a
@@ -10,7 +10,7 @@
 - **No false positives.** This runs in ``pre_build``; a spurious failure blocks a
   release. The predicate is "rmtree would delete tracked files", NOT "the path
   sits under an allowlist prefix" — those differ, and the prefix form flagged six
-  safe autocti_workspace call sites.
+  safe call sites in a real workspace (see the regression test below).
 - **No silent under-reporting.** An argument the resolver cannot evaluate is
   reported and skipped, never guessed.
 """
@@ -45,8 +45,8 @@ def _resolve_call_arg(src: str):
 def test_resolves_multi_argument_path():
     """`Path("dataset", "multi_galaxy", name)` is the dominant workspace idiom.
 
-    Handling only the single-argument form left ~31% of autolens_workspace call
-    sites unresolved.
+    Handling only the single-argument form left ~31% of the call sites in the
+    largest workspace unresolved.
     """
     src = (
         'from pathlib import Path\n'
@@ -146,9 +146,9 @@ def _run_check(tmp_path, monkeypatch, script_src, tracked, capsys):
 def test_sibling_dir_holding_no_tracked_files_is_not_a_violation(
     tmp_path, monkeypatch, capsys
 ):
-    """The autocti_workspace shape: five doc images committed directly in
-    `dataset/overview/`, while the overview scripts regenerate
-    `dataset/overview/imaging_ci/uniform` — which holds nothing tracked.
+    """The real shape that exposed the bad predicate: a workspace commits doc
+    images directly in `dataset/<section>/`, while its scripts regenerate a
+    sibling `dataset/<section>/<generated>/` that holds nothing tracked.
 
     Deleting that destroys nothing. Prefix matching against the allowlist called
     all six such call sites release-blocking failures; containment does not.
@@ -169,7 +169,7 @@ def test_sibling_dir_holding_no_tracked_files_is_not_a_violation(
 def test_path_holding_tracked_files_without_a_releasing_token_fails(
     tmp_path, monkeypatch, capsys
 ):
-    """The PyAutoArray#470 shape itself."""
+    """The originating bug's shape: the resolved path itself holds tracked files."""
     src = (
         '"""\n__Env__\n\nENV: real_plots\n"""\n'
         'from pathlib import Path\n'
@@ -188,7 +188,7 @@ def test_path_holding_tracked_files_without_a_releasing_token_fails(
 def test_releasing_token_exempts_an_otherwise_failing_call_site(
     tmp_path, monkeypatch, capsys
 ):
-    """Same script, plus `full_datasets` — the fix shipped for #470."""
+    """Same script, plus `full_datasets` — the shape of the shipped fix."""
     src = (
         '"""\n__Env__\n\nENV: full_datasets real_plots\n"""\n'
         'from pathlib import Path\n'