Commit de828cd
fix: gate autofit[jax] to python>=3.11 in the jax extra
Follow-up to #530, from an independent Codex review of that commit.
#530 pointed autogalaxy[jax] at autofit[jax] so optax follows the jax chain.
PyAutoFit#1426 then marked autofit's own optax entry python>=3.11 after an
unmarked optax took every 3.9 CI leg red with resolution-too-deep.
But that fix lives on autofit's main. Any *released* autofit still expands
autofit[jax] to an unmarked optax — confirmed against PyPI:
autofit 2026.7.27.1 -> 'optax>=0.2.5; extra == "jax"' (no marker)
So autogalaxy[jax] was only safe when autofit came from a source checkout,
which is precisely why CI went green while the released chain stayed exposed.
CI installs all five libraries with -e, so it could never have caught this.
Marking the entry here makes the chain correct whichever autofit version pip
resolves, and restores exact pre-#530 behaviour below 3.11: every member of
the extra now carries the same gate, so the extra is a clean no-op there.
Verified in the built wheel metadata — both jax-extra entries evaluate
False on 3.9/3.10 and True on 3.11/3.12.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>1 parent 5235ad8 commit de828cd
1 file changed
Lines changed: 8 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
53 | 53 | | |
54 | 54 | | |
55 | 55 | | |
56 | | - | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
57 | 64 | | |
58 | 65 | | |
59 | 66 | | |
| |||
0 commit comments