Skip to content

Commit 2016e55

Browse files
Jammy2211claude
authored andcommitted
Replace trailing sub_size 1 with 2 in adaptive over-sampling schemes
Adaptive schemes ([4,2,1] / [8,4,1] with radial_list=[0.3,0.6]) dropped to sub_size 1 beyond 0.6", evaluating the lensed source's arcs with no over-sampling. With MGE sources this aliases compact Gaussians and degrades gradient-based searches. Every trailing 1 becomes 2; simulators ([32,8,2]) unchanged. Guide prose updated to the MGE-era justification. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
1 parent d5a677a commit 2016e55

20 files changed

Lines changed: 20 additions & 20 deletions

notebooks/chapter_2_modeling/tutorial_2_practicalities.ipynb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -221,7 +221,7 @@
221221
"source": [
222222
"over_sample_size = ag.util.over_sample.over_sample_size_via_radial_bins_from(\n",
223223
" grid=dataset.grid,\n",
224-
" sub_size_list=[8, 4, 1],\n",
224+
" sub_size_list=[8, 4, 2],\n",
225225
" radial_list=[0.3, 0.6],\n",
226226
" centre_list=[(0.0, 0.0)],\n",
227227
")\n",

notebooks/chapter_2_modeling/tutorial_3_realism_and_complexity.ipynb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,7 @@
178178
"source": [
179179
"over_sample_size = ag.util.over_sample.over_sample_size_via_radial_bins_from(\n",
180180
" grid=dataset.grid,\n",
181-
" sub_size_list=[8, 4, 1],\n",
181+
" sub_size_list=[8, 4, 2],\n",
182182
" radial_list=[0.3, 0.6],\n",
183183
" centre_list=[(0.0, 0.0)],\n",
184184
")\n",

notebooks/chapter_2_modeling/tutorial_4_dealing_with_failure.ipynb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,7 @@
179179
"source": [
180180
"over_sample_size = ag.util.over_sample.over_sample_size_via_radial_bins_from(\n",
181181
" grid=dataset.grid,\n",
182-
" sub_size_list=[8, 4, 1],\n",
182+
" sub_size_list=[8, 4, 2],\n",
183183
" radial_list=[0.3, 0.6],\n",
184184
" centre_list=[(0.0, 0.0)],\n",
185185
")\n",

notebooks/chapter_2_modeling/tutorial_5_linear_profiles.ipynb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,7 @@
193193
"source": [
194194
"over_sample_size = ag.util.over_sample.over_sample_size_via_radial_bins_from(\n",
195195
" grid=dataset.grid,\n",
196-
" sub_size_list=[8, 4, 1],\n",
196+
" sub_size_list=[8, 4, 2],\n",
197197
" radial_list=[0.3, 0.6],\n",
198198
" centre_list=[(0.0, 0.0)],\n",
199199
")\n",

notebooks/chapter_2_modeling/tutorial_6_masking.ipynb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@
171171
"source": [
172172
"over_sample_size = ag.util.over_sample.over_sample_size_via_radial_bins_from(\n",
173173
" grid=dataset.grid,\n",
174-
" sub_size_list=[8, 4, 1],\n",
174+
" sub_size_list=[8, 4, 2],\n",
175175
" radial_list=[0.3, 0.6],\n",
176176
" centre_list=[(0.0, 0.0)],\n",
177177
")\n",

notebooks/chapter_2_modeling/tutorial_7_results.ipynb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@
131131
"\n",
132132
"over_sample_size = ag.util.over_sample.over_sample_size_via_radial_bins_from(\n",
133133
" grid=dataset.grid,\n",
134-
" sub_size_list=[8, 4, 1],\n",
134+
" sub_size_list=[8, 4, 2],\n",
135135
" radial_list=[0.3, 0.6],\n",
136136
" centre_list=[(0.0, 0.0)],\n",
137137
")\n",

notebooks/chapter_3_search_chaining/tutorial_1_search_chaining.ipynb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,7 @@
166166
"\n",
167167
"over_sample_size = ag.util.over_sample.over_sample_size_via_radial_bins_from(\n",
168168
" grid=dataset.grid,\n",
169-
" sub_size_list=[8, 4, 1],\n",
169+
" sub_size_list=[8, 4, 2],\n",
170170
" radial_list=[0.3, 0.6],\n",
171171
" centre_list=[(0.0, 0.0)],\n",
172172
")\n",

notebooks/chapter_3_search_chaining/tutorial_2_prior_passing.ipynb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@
145145
"\n",
146146
"over_sample_size = ag.util.over_sample.over_sample_size_via_radial_bins_from(\n",
147147
" grid=dataset.grid,\n",
148-
" sub_size_list=[8, 4, 1],\n",
148+
" sub_size_list=[8, 4, 2],\n",
149149
" radial_list=[0.3, 0.6],\n",
150150
" centre_list=[(0.0, 0.0)],\n",
151151
")\n",

notebooks/chapter_3_search_chaining/tutorial_3_x2_galaxies.ipynb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,7 @@
168168
"\n",
169169
"over_sample_size = ag.util.over_sample.over_sample_size_via_radial_bins_from(\n",
170170
" grid=dataset.grid,\n",
171-
" sub_size_list=[8, 4, 1],\n",
171+
" sub_size_list=[8, 4, 2],\n",
172172
" radial_list=[0.3, 0.6],\n",
173173
" centre_list=[(0.0, -1.0), (0.0, 1.0)],\n",
174174
")\n",

notebooks/chapter_4_pixelizations/tutorial_5_model_fit.ipynb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,7 @@
149149
"\n",
150150
"over_sample_size = ag.util.over_sample.over_sample_size_via_radial_bins_from(\n",
151151
" grid=dataset.grid,\n",
152-
" sub_size_list=[8, 4, 1],\n",
152+
" sub_size_list=[8, 4, 2],\n",
153153
" radial_list=[0.3, 0.6],\n",
154154
" centre_list=[(0.0, 0.0)],\n",
155155
")\n",

0 commit comments

Comments
 (0)