Onchain Module Cleanup (Legacy AidEscrow Design)

[Cedarich]

Description

Clean up outdated or legacy artifacts in app/onchain that still refer to an older pool-based AidEscrow design and outdated method names, so contributors are not confused by conflicting documentation and tests.

Requirements

• Review and update app/onchain/README.md:
  • Align method reference and invariants with the current aid_escrow implementation in contracts/aid_escrow/src/lib.rs.
  • Remove or clearly mark legacy concepts such as fund, disburse, revoke, and refund if they are not part of the current contract interface.
• Review app/onchain/contracts/aid_escrow/tests/core_flow.rs:
  • This test file uses the legacy API (init, fund, claim, revoke, refund) and pool model.
  • Decide whether to:
    • Refactor it to target the current aid_escrow contract design, or
    • Move it to a clearly marked legacy/ or archive/ folder, or remove it if no longer relevant.
• Ensure app/onchain/CONTRIBUTING.md examples and code snippets are consistent with the current contract API (method names, arguments, and error types).
• After cleanup, there should be a single, coherent contract model exposed to contributors, with no conflicting docs or tests.

Complexity

• Level: 200

[drips-wave]

This issue has been added to the Stellar Wave Program and is worth 200 Points.

🧑‍💻 Interested in contributing? Apply to work on this issue on Drips Wave, earn points, and receive rewards.

Warning

Only applications submitted via the apply link above will be considered. Please do not apply by commenting on the issue or opening a PR directly.

🤠 Repo maintainers: You can manage this issue's Points and Complexity on your Maintainer Dashboard here. Please keep an eye on applications and respond quickly 💙

ℹ️ Learn more about Drips Wave

[Markadrian6399]

@Markadrian6399 has applied to work on this issue as part of the Stellar Wave Program's 2nd wave.

ello 👋,

I’d like to request to work on the issue “Onchain Module Cleanup (Legacy AidEscrow Design)”.

I understand this task involves reviewing and refactoring legacy onchain components related to the AidEscrow design, removing outdated logic, and improving clarity, maintainability, and security. I’m comfortable working with smart contract architecture, legacy cleanup, and ensuring changes are well-tested and documented.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Markadrian6399 to this issue.

[drips-wave]

Congratulations, @Markadrian6399! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on February 26, 2026.

🧑‍💻 @Markadrian6399: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

Warning

When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are issued when this issue is marked as completed by the maintainer.

🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

🌊 Happy Wave 🌊