FIX: Fix an issue with cursor jump in table cell

[deniszografski]

@marijnh
I encountered a problem when the user wants to choose a different cell and in condition that the previous one has some content.

I also recorded a short gif demonstrating the problem

and I also made a solution as part of this PR.

P.S.
It may not be in line with the best practices of the whole lib but it can serve as an inspiration for a potential fix. Thanks in advance.

Stack:

• browser: Google Chrome Version 111.0.5563.64
• prosemirror-view- 1.30.2
• prosemirror-collab - 1.30.0
• prosemirror-tables - 1.2.5

[marijnh]

Could you describe the problem this is intended to fix in a bit more detail?

[deniszografski]

@marijnh
Yes, of course.

I would like to have the same behavior as it was in version prosemirror-view- 1.25.0.

I would like to click anywhere within the table cell to stay in that table cell without changing my selection and thus performing the position of the cursor in the next cell.

If you look at the gif I recorded, you can notice that every time I click on the cell, the cursor ends up in the cell next to it unless I focus on the very beginning of the cell. In this case, the cursor remains in that, selected cell.

I hope I was able to explain the problem more closely.

UPDATE

I can confirm that my current solution will just prevent execution of this part of source code:
updateSelection(this.view, Selection.near(this.view.state.doc.resolve(pos.pos)), "pointer") event.preventDefault()

which causes the expected behavior of selection.

I'm aware that the solution must be more sophisticated and precise.
Could we at least open a bug for that problem?

[marijnh]

I cannot reproduce the problem you are describing. This happens in Chrome, right, when you click around to move the cursor between adjacent empty cells?

[deniszografski]

@marijnh

Exactly, only in Chrome.

But after debugging I noticed that almost every time this.view.state.selection.visible is undefined.
I'll definitely have to look into how that happens.

Maybe updating the table module will fix the problem. ¯_(ツ)_/¯