Тесты

ProklUng · Jun 2, 2021 · c1bd6ba · c1bd6ba
1 parent 1a1e4c8
commit c1bd6ba
Show file tree

Hide file tree

Showing 13 changed files with 314 additions and 19 deletions.
diff --git a/src/Framework/SymfonyCompilerPassBag.php b/src/Framework/SymfonyCompilerPassBag.php
@@ -23,12 +23,6 @@ class SymfonyCompilerPassBag extends AbstractSymfonyCompilerPassBag
      * @var array $standartCompilerPasses Пассы Symfony.
      */
     protected $standartCompilerPasses = [
-        [
-            'pass' => ControllerArgumentValueResolverPass::class,
-        ],
-        [
-            'pass' => RegisterControllerArgumentLocatorsPass::class,
-        ],
         [
             'pass' => RoutingResolverPass::class,
         ],
@@ -38,10 +32,6 @@ class SymfonyCompilerPassBag extends AbstractSymfonyCompilerPassBag
         [
             'pass' => PropertyInfoPass::class,
         ],
-        [
-            'pass' => RemoveEmptyControllerArgumentLocatorsPass::class,
-            'phase' => PassConfig::TYPE_BEFORE_REMOVING,
-        ],
         [
             'pass' => AddConstraintValidatorsPass::class,
         ],

diff --git a/src/Framework/SymfonyCompilerPassBagLight.php b/src/Framework/SymfonyCompilerPassBagLight.php
@@ -21,12 +21,6 @@ class SymfonyCompilerPassBagLight extends AbstractSymfonyCompilerPassBag
      * @var array $standartCompilerPasses Пассы Symfony.
      */
     protected $standartCompilerPasses = [
-        [
-            'pass' => ControllerArgumentValueResolverPass::class,
-        ],
-        [
-            'pass' => RegisterControllerArgumentLocatorsPass::class,
-        ],
         [
             'pass' => RoutingResolverPass::class,
         ],

diff --git a/src/ServiceProvider.php b/src/ServiceProvider.php
@@ -11,6 +11,7 @@
 use Prokl\ServiceProvider\Services\AppKernel;
 use Prokl\ServiceProvider\Utils\ErrorScreen;
 use Psr\Container\ContainerInterface as PsrContainerInterface;
+use RuntimeException;
 use Symfony\Bridge\ProxyManager\LazyProxy\PhpDumper\ProxyDumper;
 use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
 use Symfony\Component\Config\ConfigCache;
@@ -755,10 +756,18 @@ private function loadContainerConfig(string $fileName, ContainerBuilder $contain
      * @throws Exception Ошибки контейнера.
      *
      * @since 06.11.2020
+     * @throws RuntimeException Когда директория с конфигами не существует.
      */
     private function configureContainer(ContainerBuilder $container, LoaderInterface $loader): void
     {
         $confDir = $_SERVER['DOCUMENT_ROOT'] . $this->configDir;
+
+        if (!@file_exists($confDir)) {
+            throw new RuntimeException(
+                'Config directory ' . $confDir . ' not exist.'
+            );
+        }
+
         $container->setParameter('container.dumper.inline_class_loader', true);
 
         try {

diff --git a/src/Services/AppKernel.php b/src/Services/AppKernel.php
@@ -8,6 +8,7 @@
 use LogicException;
 use Symfony\Component\Config\Loader\LoaderInterface;
 use Symfony\Component\DependencyInjection\ContainerInterface;
+use Symfony\Component\HttpKernel\Bundle\BundleInterface;
 use Symfony\Component\HttpKernel\Kernel;
 
 /**
@@ -63,7 +64,7 @@ public function getCacheDir(): string
     {
         $cachePath = $this->getProjectDir() . '/bitrix/cache/';
         if (!@file_exists($cachePath)) {
-            @mkdir($cachePath);
+            @mkdir($cachePath, 0777, true);
         }
 
         return $cachePath;
@@ -199,11 +200,19 @@ public function registerContainerConfiguration(LoaderInterface $loader)
     /**
      * Регистрация бандла.
      *
-     * @return iterable
+     * @return iterable|BundleInterface[]
+     *
+     * @since 02.06.2021 Если файл не существует - игнорим.
      */
     public function registerBundles(): iterable
     {
-        $contents = require $this->getProjectDir() . '/local/configs/bundles.php';
+        $bundleConfigPath = $this->getProjectDir() . '/local/configs/bundles.php';
+
+        if (!@file_exists($bundleConfigPath)) {
+            return [];
+        }
+
+        $contents = require $bundleConfigPath;
 
         foreach ($contents as $class => $envs) {
             if ($envs[$this->environment] ?? $envs['all'] ?? false) {

diff --git a/tests/Cases/BundlesLoaderTest.php b/tests/Cases/BundlesLoaderTest.php
@@ -0,0 +1,189 @@
+<?php
+
+namespace Prokl\ServiceProvider\Tests\Cases;
+
+use InvalidArgumentException;
+use Prokl\ServiceProvider\Bundles\BundlesLoader;
+use Prokl\ServiceProvider\Tests\Fixtures\DummyService;
+use Prokl\ServiceProvider\Tests\Fixtures\TestingBundle;
+use Prokl\TestingTools\Base\BaseTestCase;
+use Prokl\TestingTools\Tools\PHPUnitUtils;
+use ReflectionException;
+use Symfony\Component\DependencyInjection\ContainerBuilder;
+
+/**
+ * Class BundlesLoaderTest
+ * @package Prokl\ServiceProvider\Tests\Cases
+ *
+ * @since 01.06.2021
+ */
+class BundlesLoaderTest extends BaseTestCase
+{
+    /**
+     * @var BundlesLoader $obTestObject
+     */
+    protected $obTestObject;
+
+    /**
+     * @var ContainerBuilder $dummyContainer
+     */
+    private $dummyContainer;
+
+    /**
+     * @inheritDoc
+     */
+    protected function setUp(): void
+    {
+        parent::setUp();
+        $_SERVER['DOCUMENT_ROOT'] = __DIR__;
+        $_ENV['DEBUG'] = true;
+
+        $this->dummyContainer = new ContainerBuilder();
+        $this->obTestObject = new BundlesLoader(
+            $this->dummyContainer,
+            '/../Fixtures/bundles.php'
+        );
+    }
+
+    /**
+     * load(). Нормальный ход вещей.
+     *
+     * @return void
+     */
+    public function testLoad() : void
+    {
+        $this->obTestObject->load();
+
+        $result = $this->obTestObject->bundles();
+
+        $this->assertCount(1, $result);
+        $this->assertSame('TestingBundle', array_key_first($result));
+        $this->assertInstanceOf(TestingBundle::class, $result['TestingBundle']);
+    }
+
+    /**
+     * load(). Несуществующий конфиг.
+     *
+     * @return void
+     */
+    public function testLoadDefaultPath() : void
+    {
+        $this->obTestObject = new BundlesLoader(
+            $this->dummyContainer,
+            '/../Fixtures/fake.php' // Несуществующий конфиг
+        );
+
+        $this->obTestObject->load();
+
+        $result = $this->obTestObject->bundles();
+
+        $this->assertEmpty($result);
+    }
+
+    /**
+     * load(). Бандл без метода RegisterExtension.
+     *
+     * @return void
+     */
+    public function testLoadWithoutRegisterExtension() : void
+    {
+        $this->obTestObject = new BundlesLoader(
+            $this->dummyContainer,
+            '/../Fixtures/invalid_bundles.php'
+        );
+
+        $this->expectException(InvalidArgumentException::class);
+        $this->expectExceptionMessage('Bundle TestingInvalidBundle dont have implemented getContainerExtension method.');
+
+        $this->obTestObject->load();
+    }
+
+    /**
+     * load(). Invalid class.
+     *
+     * @return void
+     */
+    public function testLoadInvalidClass() : void
+    {
+        $this->obTestObject = new BundlesLoader(
+            $this->dummyContainer,
+            '/../Fixtures/fake_bundles.php'
+        );
+
+        $this->expectException(InvalidArgumentException::class);
+        $this->expectExceptionMessage('Bundle class Prokl\ServiceProvider\Tests\Fixtures\FakeBundle not exist.');
+
+        $this->obTestObject->load();
+    }
+
+    /**
+     * boot(). Проверяется, что в класс бандла загоняется полноценный контейнер.
+     * И, что у бандла вызван метод boot.
+     *
+     * @return void
+     * @throws ReflectionException Ошибки рефлексии.
+     */
+    public function testBoot() : void
+    {
+        $this->obTestObject->load();
+
+        $this->dummyContainer->register('test.service', DummyService::class);
+        $this->obTestObject->boot($this->dummyContainer);
+
+        $result = $this->obTestObject->bundles();
+        $bundle = current($result);
+
+        $container = PHPUnitUtils::getProtectedProperty(
+            $bundle,
+            'container'
+        );
+
+        $this->assertTrue(
+            $container->has('test.service'),
+            'Контейнер не обработался до конца. Ожидаемого сервиса нет.'
+        );
+
+        $this->assertTrue(
+            $bundle->booted,
+            'Метод boot бандла не вызывался.'
+        );
+    }
+
+    /**
+     * getBundlesMap().
+     *
+     * @return void
+     */
+    public function testGetBundlesMap() : void
+    {
+        $this->obTestObject->load();
+        $result = $this->obTestObject::getBundlesMap();
+
+        $this->assertCount(1, $result);
+        $this->assertSame('TestingBundle', array_key_first($result));
+        $this->assertInstanceOf(TestingBundle::class, $result['TestingBundle']);
+    }
+
+    /**
+     * bootAfterCompilingContainer().
+     *
+     * @return void
+     */
+    public function testBootAfterCompilingContainer() : void
+    {
+        $this->obTestObject->load();
+        $result = $this->obTestObject::getBundlesMap();
+        $bundle = get_class(current($result));
+
+        $this->dummyContainer->setParameter('kernel.bundles', [
+            $bundle
+        ]);
+
+        $this->obTestObject::bootAfterCompilingContainer($this->dummyContainer);
+
+        $this->assertTrue(
+            $bundle::$booted_static,
+            'Метод boot не запускался.'
+        );
+    }
+}
diff --git a/tests/Fixtures/DummyService.php b/tests/Fixtures/DummyService.php
@@ -0,0 +1,12 @@
+<?php
+
+namespace Prokl\ServiceProvider\Tests\Fixtures;
+
+/**
+ * Class DummyService
+ * @package Prokl\ServiceProvider\Tests\Fixtures
+ */
+class DummyService
+{
+
+}
diff --git a/tests/Fixtures/TestingBundle.php b/tests/Fixtures/TestingBundle.php
@@ -0,0 +1,34 @@
+<?php
+
+namespace Prokl\ServiceProvider\Tests\Fixtures;
+
+use Symfony\Component\HttpKernel\Bundle\Bundle;
+
+/**
+ * Class TestingBundle
+ * @package Prokl\ServiceProvider\Tests\Fixtures
+ */
+class TestingBundle extends Bundle
+{
+    public $booted = false;
+
+    public static $booted_static = false;
+
+    /**
+     * @inheritDoc
+     */
+    public function getContainerExtension()
+    {
+        return new TestingBundleExtension();
+    }
+
+    /**
+     * @inheritDoc
+     */
+    public function boot() : void
+    {
+        parent::boot();
+        $this->booted = true;
+        static::$booted_static = true;
+    }
+}
diff --git a/tests/Fixtures/TestingBundleExtension.php b/tests/Fixtures/TestingBundleExtension.php
@@ -0,0 +1,23 @@
+<?php
+
+namespace Prokl\ServiceProvider\Tests\Fixtures;
+
+use Exception;
+use Symfony\Component\DependencyInjection\ContainerBuilder;
+use Symfony\Component\HttpKernel\DependencyInjection\Extension;
+
+/**
+ * Class TestingBundleExtension
+ * @package Prokl\ServiceProvider\Tests\Fixtures
+ */
+class TestingBundleExtension extends Extension
+{
+    /**
+     * @inheritDoc
+     * @throws Exception
+     */
+    public function load(array $configs, ContainerBuilder $container) : void
+    {
+
+    }
+}
diff --git a/tests/Fixtures/TestingInvalidBundle.php b/tests/Fixtures/TestingInvalidBundle.php
@@ -0,0 +1,14 @@
+<?php
+
+namespace Prokl\ServiceProvider\Tests\Fixtures;
+
+use Symfony\Component\HttpKernel\Bundle\Bundle;
+
+/**
+ * Class TestingInvalidBundle
+ * @package Prokl\ServiceProvider\Tests\Fixtures
+ */
+class TestingInvalidBundle extends Bundle
+{
+
+}
diff --git a/tests/Fixtures/bundles.php b/tests/Fixtures/bundles.php
@@ -0,0 +1,4 @@
+<?php
+return [
+    Prokl\ServiceProvider\Tests\Fixtures\TestingBundle::class => ['all' => true]
+];
diff --git a/tests/Fixtures/config/test_container.yaml b/tests/Fixtures/config/test_container.yaml
@@ -0,0 +1,9 @@
+services:
+  # конфигурация по умолчанию в *этом* файле
+  _defaults:
+    autowire: true
+    autoconfigure: true
+    public: true
+
+  test_service:
+    class: Prokl\ServiceProvider\Tests\Fixtures\DummyService