Skip to content

Commit a89a0af

Browse files
authored
6555 fixes integration issues (#6615)
Fixes #6555 ### Description Absolute differences such as 4.26173210144043e-06 in `test_onnx_save` looks ok, this increases the tolerances. otherwise we randomly run into integration errors because of the checks. ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. Signed-off-by: Wenqi Li <[email protected]>
1 parent a1c4371 commit a89a0af

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

tests/test_retinanet.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -183,7 +183,7 @@ def test_onnx(self, model, input_param, input_shape):
183183
data = torch.randn(input_shape)
184184
backbone = model(**input_param)
185185
if idx == 0:
186-
test_onnx_save(backbone, data, rtol=2e-3)
186+
test_onnx_save(backbone, data, rtol=2e-2, atol=1e-5)
187187
return
188188
feature_extractor = resnet_fpn_feature_extractor(
189189
backbone=backbone,
@@ -193,7 +193,7 @@ def test_onnx(self, model, input_param, input_shape):
193193
returned_layers=[1, 2],
194194
)
195195
if idx == 1:
196-
test_onnx_save(feature_extractor, data, rtol=2e-3)
196+
test_onnx_save(feature_extractor, data, rtol=2e-2, atol=1e-5)
197197
return
198198
net = RetinaNet(
199199
spatial_dims=input_param["spatial_dims"],
@@ -203,7 +203,7 @@ def test_onnx(self, model, input_param, input_shape):
203203
size_divisible=32,
204204
)
205205
if idx == 2:
206-
test_onnx_save(net, data, rtol=2e-3)
206+
test_onnx_save(net, data, rtol=2e-2, atol=1e-5)
207207

208208

209209
if __name__ == "__main__":

0 commit comments

Comments
 (0)