Skip to content

Improve data structure and rendering logic #92

Description

@raven-wing
          _:hammer_and_wrench: Refactor suggestion_

Improve data structure and rendering logic.

The current implementation relies heavily on array indices and nested arrays, which makes the code harder to maintain and understand. Consider restructuring the data to use objects with meaningful property names.

  1. Update the data structure in httpService.getCategoriesData():
// Instead of: [[category, translation], [[name, translation], ...]]
// Use:
{
  category: string;
  translation: string;
  filters: Array<{
    name: string;
    translation: string;
  }>;
}
  1. Simplify the rendering logic:
-    const sections = categoriesData.map(filtersData => (
+    const sections = categoriesData.map(({ category, translation, filters }) => (
         <div
-            key={`${filtersData[0][0]}-${filtersData[0][1]}`}
+            key={`${category}-${translation}`}
-            aria-labelledby={`filter-label-${filtersData[0][0]}-${filtersData[0][1]}`}
+            aria-labelledby={`filter-label-${category}`}
         >
-            <span id={`filter-label-${filtersData[0][0]}-${filtersData[0][1]}`}>
-                {filtersData[0][1]}
+            <span id={`filter-label-${category}`}>
+                {translation}
             </span>
-            {filtersData[1].map(([name, translation]) => (
-                <div className="form-check" key={`${filtersData[0][0]}-${name}`}>
+            {filters.map(({ name, translation }) => (
+                <div className="form-check" key={`${category}-${name}`}>
                     <label htmlFor={name}>
                         {translation}
                         <input
                             onChange={handleCheckboxChange}
                             className="form-check-input filter"
-                            data-category={filtersData[0][0]}
+                            data-category={category}
                             type="checkbox"
                             id={name}
                             value={name}
                         />
                     </label>
                 </div>
             ))}
         </div>
     ));
🧰 Tools
🪛 eslint

[error] 56-56: Curly braces are unnecessary here.

(react/jsx-curly-brace-presence)


[error] 56-56: Strings must use singlequote.

(quotes)

Originally posted by @coderabbitai[bot] in #90 (comment)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions