Skip to content

Commit 017b3fe

Browse files
authored
dont reschedule requests immediatly after canceling (#1512)
Co-authored-by: sami jaghouar <[email protected]>
1 parent a78c218 commit 017b3fe

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

src/prime_rl/orchestrator/scheduler.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -217,10 +217,9 @@ async def update_policy(self):
217217
else:
218218
futures_to_update.append((future, info.off_policy_steps + 1, info.worker, info.request_id))
219219

220-
# Remove cancelled and reschedule
220+
# Remove cancelled
221221
for future, worker in futures_to_remove:
222222
self.inflight_group_rollouts.pop(future, None)
223-
await self.schedule_group_rollout()
224223

225224
# Update off-policy steps for remaining
226225
for future, off_policy_steps, worker, request_id in futures_to_update:
@@ -232,7 +231,9 @@ async def update_policy(self):
232231
)
233232

234233
if len(futures_to_remove) > 0:
235-
self.logger.warning(f"Cancelled and re-scheduled {len(futures_to_remove)} old rollout requests.")
234+
self.logger.warning(
235+
f"Cancelled {len(futures_to_remove)} old rollout requests (will refill naturally). Consider increasing max_off_policy_steps to avoid this."
236+
)
236237

237238
self.ckpt_step = next_ckpt_step
238239

0 commit comments

Comments
 (0)