Replies: 1 comment 2 replies
|
Thanks for reporting this caveat 👍 We already display a message at the end of the update to warn users that, if images do not appear correctly, they need to regenerate them. But if I understand correctly, you’re saying that when new formats are added between v1 and v2 for example, they are not picked up automatically. Is that correct? I think this is something we should discuss with @Quetzacoalt91. Maybe we should handle it in the migration script for the update we need to think how to handle it better. |
2 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
The problem
Upgrading to 9.1.0 went fine, along with an upgrade to Hummingbird 2.0, except the them now looks for image sizes default_lg and default_sm (replacing default_s).
In turn, the generated page has a srcset of the form " 216w, {the medium image}, 336w", thus causing alt text to appear due to the missing images.
This is the result of 0cdb6d45c47b7c9197bbe469778ad6581a4c2dde
The solution
Ideally, the upgrade to 9.1 adds the new image sizes. Less ideally, the store admin is warned that they need to add the new formats to the image settings.
Additional context
No response
Do you plan to work on this subject?
All reactions