Hot path storage read optimization

[greatest0fallt1me]

Description

• Remove redundant persistent reads without harming clarity.

Requirements and context

• Must be secure, tested, and documented.
• Should be efficient and easy to review for auditors and integrators.
• Scope is Predictify Hybrid Soroban smart contracts in predictify-contracts only (no frontend or backend services).

Suggested execution

• Fork the repository and create a branch:
  • git checkout -b feature/gas-hot-path
• Implement changes:
  1. Contract / module: update logic in contracts/predictify-hybrid/src/bets.rs and related modules as required.
  2. Tests: extend or add gas tests (and supporting test utilities under contracts/predictify-hybrid/src/tests/ when applicable).
  3. Documentation: update or add docs/gas/GAS_OPTIMIZATION.md; add a link from docs/README.md when adding new top-level docs.
  4. Comments: use Rust doc comments (///, //!) on all new or changed public contract API — equivalent discipline to NatSpec for Solidity.

Primary touchpoints: contracts/predictify-hybrid/src/bets.rs, contracts/predictify-hybrid/src/resolution.rs

Test and commit

• Run cargo test -p predictify-hybrid and narrow with filters while iterating.
• Add regression tests for every bug or ambiguity found during review.
• In the PR, include summarized test output and short security notes (threat model, invariants proven, explicit non-goals).

Example commit message

perf(contract): optimize hot storage reads

Guidelines

• Target ≥ 95% line coverage on modules touched (e.g. cargo llvm-cov / cargo tarpaulin per repo conventions).
• Documentation must be sufficient for an external integrator without reading all Rust internals.
• Timeframe: 96 hours from assignment.

[drips-wave]

This issue has been added to the Stellar Wave Program and is worth 200 Points.

🧑‍💻 Interested in contributing? Apply to work on this issue on Drips Wave, earn points, and receive rewards.

Warning

Only applications submitted via the apply link above will be considered. Please do not apply by commenting on the issue or opening a PR directly.

🤠 Repo maintainers: You can manage this issue's Points and Complexity on your Maintainer Dashboard here. Please keep an eye on applications and respond quickly 💙

ℹ️ Learn more about Drips Wave