Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

this plugin doesn't support DiffEditor? #57

Open
lynnxyli opened this issue Jun 14, 2024 · 2 comments
Open

this plugin doesn't support DiffEditor? #57

lynnxyli opened this issue Jun 14, 2024 · 2 comments
Assignees
Labels
available-for-pull-request This feature is yet to be developed, so Pull Request from open source contributors are welcome good first issue Good for newcomers

Comments

@lynnxyli
Copy link

my code is
image
but it throws
image
the editor is instance of IStandaloneCodeEditor here, is there a way i can use this plugin in IStandaloneDiffEditor's ModifiedEditor ?

@Pranomvignesh
Copy link
Owner

No, This plugin is not intended to be used in Diff Editor.
As I'm using some internal functions of monaco editor, I want the instance to be exactly ICodeEditor.
If you feel there is a proper usecase for this plugin in Diff Editor, feel free to create a pull request incorporating that functionality

@Pranomvignesh Pranomvignesh self-assigned this Jun 14, 2024
@Pranomvignesh Pranomvignesh added good first issue Good for newcomers available-for-pull-request This feature is yet to be developed, so Pull Request from open source contributors are welcome labels Jun 14, 2024
@Hideer
Copy link

Hideer commented Dec 23, 2024

@lynnxyli Hello, how did you solve it in the end?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
available-for-pull-request This feature is yet to be developed, so Pull Request from open source contributors are welcome good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants