Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing feedback for Update-MarkdownModuleFile #672

Closed
sdwheeler opened this issue Aug 23, 2024 · 1 comment
Closed

Testing feedback for Update-MarkdownModuleFile #672

sdwheeler opened this issue Aug 23, 2024 · 1 comment
Labels
Issue-Enhancement Issue is more of a feature request than a bug Needs-Triage The issue is new and needs to be triaged by a work group. Resolution-Fixed The issue is fixed.
Milestone

Comments

@sdwheeler
Copy link
Collaborator

sdwheeler commented Aug 23, 2024

Summary of the new feature / enhancement

  1. In PlatyPS build 27d5ffe, Update-MarkdownModuleFile doesn't create .bak files like Update-MarkdownCommandHelp does. Should it?
  2. The -ModuleFile parameter takes a ModuleFileInfo object, which requires you to import a markdown file. Should it take a PSModuleInfo object (like from Get-Module)?
    • Can we assume that it is in the -OutputFolder location?
    • Should this be a path-type parameter that points to the file to be updated?
  3. Add -Confirm and -WhatIf
    4. Remove -HelpUri (not relevant to command)

I am open to further discussion.

Proposed technical implementation details (optional)

No response

@sdwheeler sdwheeler added Issue-Enhancement Issue is more of a feature request than a bug Needs-Triage The issue is new and needs to be triaged by a work group. labels Aug 23, 2024
@sdwheeler sdwheeler added this to the Planned for V1 milestone Aug 23, 2024
@sdwheeler
Copy link
Collaborator Author

sdwheeler commented Sep 17, 2024

Items 1-3 fixed in OPS10.

Still need to remove -HelpUri - tracked in #670

@sdwheeler sdwheeler added the Resolution-Fixed The issue is fixed. label Sep 17, 2024
@sdwheeler sdwheeler modified the milestones: Planned for V1, OPS-Release Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Enhancement Issue is more of a feature request than a bug Needs-Triage The issue is new and needs to be triaged by a work group. Resolution-Fixed The issue is fixed.
Projects
None yet
Development

No branches or pull requests

1 participant