Skip to content

Commit 53be991

Browse files
authored
Make messages of UseCorrectCasing more detailed (#1843)
1 parent e650b46 commit 53be991

File tree

3 files changed

+52
-40
lines changed

3 files changed

+52
-40
lines changed

Rules/Strings.Designer.cs

+46-37
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Rules/Strings.resx

+4-1
Original file line numberDiff line numberDiff line change
@@ -1099,7 +1099,7 @@
10991099
<value>For better readability and consistency, use the exact casing of the cmdlet/function/parameter.</value>
11001100
</data>
11011101
<data name="UseCorrectCasingError" xml:space="preserve">
1102-
<value>Cmdlet/Function/Parameter does not match its exact casing '{0}'.</value>
1102+
<value>Function/Cmdlet '{0}' does not match its exact casing '{1}'.</value>
11031103
</data>
11041104
<data name="UseCorrectCasingName" xml:space="preserve">
11051105
<value>UseCorrectCasing</value>
@@ -1188,4 +1188,7 @@
11881188
<data name="AvoidUsingBrokenHashAlgorithmsName" xml:space="preserve">
11891189
<value>AvoidUsingBrokenHashAlgorithms</value>
11901190
</data>
1191+
<data name="UseCorrectCasingParameterError" xml:space="preserve">
1192+
<value>Parameter '{0}' of function/cmdlet '{1}' does not match its exact casing '{2}'.</value>
1193+
</data>
11911194
</root>

Rules/UseCorrectCasing.cs

+2-2
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ public override IEnumerable<DiagnosticRecord> AnalyzeScript(Ast ast, string file
5858
if (!commandName.Equals(correctlyCasedCommandName, StringComparison.Ordinal))
5959
{
6060
yield return new DiagnosticRecord(
61-
string.Format(CultureInfo.CurrentCulture, Strings.UseCorrectCasingError, commandName, shortName),
61+
string.Format(CultureInfo.CurrentCulture, Strings.UseCorrectCasingError, commandName, correctlyCasedCommandName),
6262
GetCommandExtent(commandAst),
6363
GetName(),
6464
DiagnosticSeverity.Warning,
@@ -91,7 +91,7 @@ public override IEnumerable<DiagnosticRecord> AnalyzeScript(Ast ast, string file
9191
if (!parameterName.Equals(correctlyCasedParameterName, StringComparison.Ordinal))
9292
{
9393
yield return new DiagnosticRecord(
94-
string.Format(CultureInfo.CurrentCulture, Strings.UseCorrectCasingError, commandName, parameterName),
94+
string.Format(CultureInfo.CurrentCulture, Strings.UseCorrectCasingParameterError, parameterName, commandName, correctlyCasedParameterName),
9595
GetCommandExtent(commandAst),
9696
GetName(),
9797
DiagnosticSeverity.Warning,

0 commit comments

Comments
 (0)