Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 🎸 add field to expose unmatched permissions #1434

Merged
merged 2 commits into from
Jan 28, 2025

Conversation

sansan
Copy link
Contributor

@sansan sansan commented Jan 22, 2025

Description

adds unmatchedPermissions for PermissionedAccount to return a list of permissions that the PermissionedAccount has but that are not present in SDK (wrong module name, incorrect extrinsic, or a combination)

JIRA Link

https://polymesh.atlassian.net/browse/DA-1412

@sansan sansan requested a review from a team as a code owner January 22, 2025 21:26
polymath-eric
polymath-eric previously approved these changes Jan 24, 2025
@sansan
Copy link
Contributor Author

sansan commented Jan 28, 2025

/fast-forward

@prashantasdeveloper
Copy link
Collaborator

Triggered from #1434 (comment) by @​sansan.

Trying to fast forward alpha (c708387) to feat/DA-1412 (e47b6f4).

Target branch (alpha):

commit c708387f79b22fb59d55a728df05f82ae8d27f55 (HEAD -> alpha, origin/alpha)
Author: Toms <toms@veidemanis.lv>
Date:   Wed Dec 18 15:24:02 2024 +0200

    feat: 🎸 get permissions required for a procedure

Pull request (feat/DA-1412):

commit e47b6f47c32bdd6e8fcc647b3add210cb29da287 (pull_request/feat/DA-1412)
Author: Toms <toms@veidemanis.lv>
Date:   Tue Jan 28 02:48:23 2025 +0200

    refactor: 💡 pr comments

Fast forwarding alpha (c708387) to feat/DA-1412 (e47b6f4).

$ git push origin e47b6f47c32bdd6e8fcc647b3add210cb29da287:alpha
remote: error: GH006: Protected branch update failed for refs/heads/alpha.        
remote: 
remote: - 10 of 10 required status checks have not succeeded: 4 expected.        
To https://github.com/PolymeshAssociation/polymesh-sdk.git
 ! [remote rejected]   e47b6f47c32bdd6e8fcc647b3add210cb29da287 -> alpha (protected branch hook declined)
error: failed to push some refs to 'https://github.com/PolymeshAssociation/polymesh-sdk.git'

@polymath-eric
Copy link
Collaborator

/fast-forward

@prashantasdeveloper prashantasdeveloper merged commit e47b6f4 into alpha Jan 28, 2025
12 checks passed
@prashantasdeveloper prashantasdeveloper deleted the feat/DA-1412 branch January 28, 2025 17:30
@prashantasdeveloper
Copy link
Collaborator

🎉 This PR is included in version 27.3.0-alpha.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@prashantasdeveloper
Copy link
Collaborator

🎉 This PR is included in version 27.3.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@prashantasdeveloper
Copy link
Collaborator

🎉 This PR is included in version 27.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants