chore: fix tests and eslint

Author: sansan

tests/.eslintrc

@@ -0,0 +1,50 @@
+module.exports = {
+  parser: '@typescript-eslint/parser',
+  env: {
+    browser: true,
+    jest: true,
+    node: true,
+    es6: true,
+  },
+  rules: {
+    '@typescript-eslint/indent': 'off',
+    quotes: ['error', 'single', { avoidEscape: true }],
+    'simple-import-sort/imports': 'error',
+    'sort-imports': 'off',
+    'import/order': 'off',
+    'no-dupe-class-members': 'off',
+    'no-shadow': 'off',
+    '@typescript-eslint/no-shadow': ['error'],
+    'arrow-parens': 'off',
+    'no-useless-constructor': 'off',
+    '@typescript-eslint/no-useless-constructor': 'error',
+    'no-only-tests/no-only-tests': [
+      'error',
+      {
+        focus: ['only', 'skip'],
+      },
+    ],
+  },
+  plugins: [
+    '@typescript-eslint',
+    'simple-import-sort',
+    'node',
+    'import',
+    'prettier',
+    'promise',
+    'no-only-tests',
+  ],
+  parserOptions: {
+    sourceType: 'module',
+    project: './tsconfig.json',
+    tsconfigRootDir: __dirname,
+    extraFileExtensions: ['.cjs'],
+  },
+  extends: [
+    'standard',
+    'semistandard',
+    'plugin:@typescript-eslint/recommended',
+    'prettier',
+  ],
+  ignorePatterns: ['src/polkadot/', 'src/middleware/', 'docs/*', '.eslintrc.cjs'],
+};

tests/.eslintrc.cjs

@@ -46,9 +46,21 @@
   },
   "dependencies": {
     "@polymeshassociation/local-signing-manager": "^3.5.2",
-    "@polymeshassociation/polymesh-sdk": "29.0.0-next.4",
+    "@polymeshassociation/polymesh-sdk": "29.1.0-beta.3",
     "cross-fetch": "^4.1.0",
     "dotenv": "^16.5.0"
   },
+  "resolutions": {
+    "@polkadot/api": "11.2.1",
+    "@polkadot/api-augment": "11.2.1",
+    "@polkadot/api-base": "11.2.1",
+    "@polkadot/api-derive": "11.2.1",
+    "@polkadot/rpc-augment": "11.2.1",
+    "@polkadot/rpc-core": "11.2.1",
+    "@polkadot/rpc-provider": "11.2.1",
+    "@polkadot/types": "11.2.1",
+    "@polkadot/types-augment": "11.2.1",
+    "@polkadot/types-known": "11.2.1"
+  },
   "packageManager": "[email protected]+sha512.1fc009bc09d13cfd0e19efa44cbfc2b9cf6ca61482725eb35bbc5e257e093ebf4130db6dfe15d604ff4b79efd8e1e8e99b25fa7d0a6197c9f9826358d4d65c3c"
 }

tests/package.json

@@ -2,18 +2,18 @@ import { TestFactory } from '~/helpers';
 import { RestClient } from '~/rest';
 import { createAssetParams } from '~/rest/assets/params';
 import { ProcessMode } from '~/rest/common';
-import { Identity } from '~/rest/identities/interfaces';
-import { RestSuccessResult } from '~/rest/interfaces';
-import { fungibleInstructionParams } from '~/rest/settlements/params';
-
-import { expectBasicTxInfo } from '../utils';
 import {
-  createDividendDistributionParams,
   claimDividendDistributionParams,
+  createDividendDistributionParams,
+  modifyDistributionCheckpointParams,
   payDividendDistributionParams,
   reclaimDividendDistributionParams,
-  modifyDistributionCheckpointParams,
 } from '~/rest/corporate-actions/params';
+import { Identity } from '~/rest/identities/interfaces';
+import { RestSuccessResult } from '~/rest/interfaces';
+import { fungibleInstructionParams } from '~/rest/settlements/params';
+
+import { expectBasicTxInfo } from '../utils';
 
 const handles = ['issuer', 'holder'];
 let factory: TestFactory;

tests/src/__tests__/rest/corporate-actions/dividend-distributions.ts

@@ -1,14 +1,12 @@
 import { LocalSigningManager } from '@polymeshassociation/local-signing-manager';
 import { Polymesh } from '@polymeshassociation/polymesh-sdk';
-import { FungibleAsset } from '@polymeshassociation/polymesh-sdk/types';
 
 import { TestFactory } from '~/helpers';
 import { fungibleAssetControllerTransfer } from '~/sdk/assets/controllerTransfer';
 
 let factory: TestFactory;
 
 describe('controllerTransfer', () => {
-  let asset: FungibleAsset;
   let sdk: Polymesh;
   let targetDid: string;
 

tests/src/__tests__/sdk/assets/controllerTransfer.ts

@@ -5,8 +5,8 @@ import { Assets } from '~/rest/assets';
 import { Claims } from '~/rest/claims/client';
 import { TxBase } from '~/rest/common';
 import { Compliance } from '~/rest/compliance';
-import { Identities } from '~/rest/identities';
 import { CorporateActions } from '~/rest/corporate-actions';
+import { Identities } from '~/rest/identities';
 import { Network } from '~/rest/network';
 import { Nfts } from '~/rest/nfts';
 import { Portfolios } from '~/rest/portfolios';

tests/src/rest/client.ts

@@ -1,5 +1,6 @@
 import { RestClient } from '~/rest/client';
 import { PostResult, RestSuccessResult, ResultSet } from '~/rest/interfaces';
+
 import {
   claimDividendDistributionParams,
   createDividendDistributionParams,

tests/src/rest/corporate-actions/client.ts

@@ -1,5 +1,6 @@
 import { BigNumber } from '@polymeshassociation/polymesh-sdk';
 import { TargetTreatment } from '@polymeshassociation/polymesh-sdk/types';
+
 import { TxBase, TxExtras } from '~/rest/common';
 
 // Shape is intentionally flexible to allow tests to pass specific values

tests/src/rest/corporate-actions/params.ts

@@ -22,15 +22,16 @@ export const fungibleAssetControllerTransfer = async (
 
   assert(asset);
 
-  const [identity, counterParty] = await Promise.all([
+  const [signerIdentity, counterParty] = await Promise.all([
     sdk.getSigningIdentity(),
     sdk.identities.getIdentity({ did: targetDid }),
   ]);
-  assert(identity);
+  assert(signerIdentity);
   const { account: counterPartyAccount } = await counterParty.getPrimaryAccount();
 
   const transferTx = await sdk.settlements.addInstruction({
-    legs: [{ asset, from: identity, to: targetDid, amount: new BigNumber(1000) }],
+    legs: [{ asset, from: signerIdentity, to: targetDid, amount: new BigNumber(1000) }],
+    venueId: undefined,
   });
   const instruction = await transferTx.run();
   assert(transferTx.isSuccess);
@@ -54,7 +55,7 @@ export const fungibleAssetControllerTransfer = async (
 
   const assetHolders = await asset.assetHolders.get();
 
-  const heldByIssuer = assetHolders.data.find(({ identity }) => identity.isEqual(identity));
+  const heldByIssuer = assetHolders.data.find(({ identity }) => identity.isEqual(signerIdentity));
   assert(heldByIssuer);
   expect(heldByIssuer.balance.eq(new BigNumber(1100)));
 
@@ -82,11 +83,11 @@ export const nonFungibleAssetControllerTransfer = async (
 
   assert(collection);
 
-  const [identity, counterParty] = await Promise.all([
+  const [signerIdentity, counterParty] = await Promise.all([
     sdk.getSigningIdentity(),
     sdk.identities.getIdentity({ did: targetDid }),
   ]);
-  assert(identity);
+  assert(signerIdentity);
   assert(counterParty);
 
   const { account: counterPartyAccount } = await counterParty.getPrimaryAccount();
@@ -128,7 +129,8 @@ export const nonFungibleAssetControllerTransfer = async (
   const nft2 = await issueTx2.run();
 
   const transferTx = await sdk.settlements.addInstruction({
-    legs: [{ asset: collection, nfts: [nft, nft2], from: identity, to: targetDid }],
+    legs: [{ asset: collection, nfts: [nft, nft2], from: signerIdentity, to: targetDid }],
+    venueId: undefined,
   });
   const instruction = await transferTx.run();
   assert(transferTx.isSuccess);
@@ -152,7 +154,7 @@ export const nonFungibleAssetControllerTransfer = async (
 
   const assetHolders = await collection.assetHolders.get({});
 
-  let heldByIssuer = assetHolders.data.find(({ identity }) => identity.isEqual(identity));
+  let heldByIssuer = assetHolders.data.find(({ identity }) => identity.isEqual(signerIdentity));
   assert(heldByIssuer);
   expect(heldByIssuer.nfts.length).toEqual(1);
   expect(heldByIssuer.nfts[0].id.eq(nft.id));
@@ -169,7 +171,7 @@ export const nonFungibleAssetControllerTransfer = async (
   assert(createPortfolioTx.isSuccess);
 
   const controllerTransferTx2 = await collection.controllerTransfer({
-    originPortfolio: { identity, id: portfolio.id },
+    originPortfolio: { identity: signerIdentity, id: portfolio.id },
     nfts: [nft2],
   });
   await controllerTransferTx2.run();
@@ -178,7 +180,7 @@ export const nonFungibleAssetControllerTransfer = async (
 
   const assetHolders2 = await collection.assetHolders.get({});
 
-  heldByIssuer = assetHolders2.data.find(({ identity }) => identity.isEqual(identity));
+  heldByIssuer = assetHolders2.data.find(({ identity }) => identity.isEqual(signerIdentity));
   assert(heldByIssuer);
   expect(heldByIssuer.nfts.length).toEqual(2);
 

tests/src/sdk/assets/controllerTransfer.ts

@@ -1,5 +1,5 @@
 import { BigNumber, Polymesh } from '@polymeshassociation/polymesh-sdk';
-import { FungibleAsset, Identity, VenueType } from '@polymeshassociation/polymesh-sdk/types';
+import { FungibleAsset, VenueType } from '@polymeshassociation/polymesh-sdk/types';
 import assert from 'node:assert';
 
 /*