Skip to content

matchOrders parameter order in Overview.md examples #33

@stefann-01

Description

@stefann-01

In the Overview.md matching scenario examples, the pseudo code shows:

matchOrders(makerOrder, [takerOrder], 50, [25])

However, the actual function signature in CTFExchange.sol has the taker order as the first parameter and maker orders as the array:

function matchOrders(
    Order memory takerOrder,
    Order[] memory makerOrders,
    uint256 takerFillAmount,
    uint256[] memory makerFillAmounts
)

Are the labels in the pseudo code intentionally different from the actual parameter naming, or should they be swapped to match the implementation?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions