Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to python 3.5 #50

Closed
mpaolini opened this issue Oct 6, 2015 · 16 comments
Closed

Port to python 3.5 #50

mpaolini opened this issue Oct 6, 2015 · 16 comments

Comments

@mpaolini
Copy link
Contributor

mpaolini commented Oct 6, 2015

No description provided.

@smurfix
Copy link
Contributor

smurfix commented Nov 18, 2015

It's probably too early to replace all @asyncio/coroutine/yield from pairs with async/await, py3.4 is still too wide-spread and the two schemes are mostly compatible.

However, using Python 3.5 does break some tests.

@dzen
Copy link
Contributor

dzen commented Nov 19, 2015

More over, I don't see python 3.5 coming on debian ( the most interesting link must be https://lists.debian.org/debian-python/2015/06/msg00036.html)

Keeping the compatibility from 3.4 to 3.5 looks like pain :(

@smurfix
Copy link
Contributor

smurfix commented Nov 19, 2015

Python 3.5 is on Debian experimental and is able to run 3.4 code just fine.
The only problem is that it exposes a nasty concurrency bug in httplib2 (used by pyrabbit) which I just submtted a pull request for.

@smurfix
Copy link
Contributor

smurfix commented Nov 20, 2015

All tests now pass when using 3.5, at least on my machine.

AFAICT there are no plans to remove yield-from style coroutines from Python3.
Thus IMHO this issue can be closed.

@mpaolini
Copy link
Contributor Author

then we just need to add python 3.5 to the tox config

@mpaolini
Copy link
Contributor Author

travis config I mean

@smurfix
Copy link
Contributor

smurfix commented Nov 20, 2015

On 20.11.2015 09:36, Marco Paolini wrote:

then we just need to add python 3.5 to the tox config

Travis config updated. Thanks for noticing.

-- Matthias Urlichs

@dzen
Copy link
Contributor

dzen commented Dec 2, 2015

Imho the first fix should be a port of asyncio.async() to asyncio.ensure_future() ?

@dzen
Copy link
Contributor

dzen commented Dec 19, 2015

It seems pyrabbit is not python 3.5 compatible :(

@smurfix
Copy link
Contributor

smurfix commented Dec 19, 2015

@dzen pyrabbit itself is perfectly 3.5 compatible. httplib2 is not.
My pull request to fix this (cf. my comment from Nov 19th, above) is here: jcgregorio/httplib2#320

@dzen
Copy link
Contributor

dzen commented Dec 21, 2015

yes, for sure, I didn't go deeper this weekend to know why pyrabbit fails on thoses CONNRESET :)

thank you for the patch on httplib2

@dzen
Copy link
Contributor

dzen commented Apr 1, 2016

Hello all,

We migrated to the git version of pyrabbit. Tests are passing.

@dzen dzen closed this as completed Apr 1, 2016
@MaxOvcharov
Copy link

Hello all,
At this moment, does aioamqp ported to python 3.5 syntax?

@RemiCardona
Copy link
Contributor

No, we're still compatible with 3.4.

@MaxOvcharov
Copy link

Ok, thank you. Do you planning to do this?

@dzen
Copy link
Contributor

dzen commented Jul 13, 2017

Hi @MaxOvcharov.

We still have a lots of python 3.4 running in our production.
As soon as we migrate them all, we will work on using the new syntax.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants